Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: runtime/vm/kernel_binary.cc

Issue 2866593003: Add an optional bound to type parameter references (Closed)
Patch Set: Don't leak the bound if it ever becomes non-null Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 #if !defined(DART_PRECOMPILED_RUNTIME) 4 #if !defined(DART_PRECOMPILED_RUNTIME)
5 5
6 #include "vm/kernel_binary.h" 6 #include "vm/kernel_binary.h"
7 #include "platform/globals.h" 7 #include "platform/globals.h"
8 #include "vm/flags.h" 8 #include "vm/flags.h"
9 #include "vm/growable_array.h" 9 #include "vm/growable_array.h"
10 #include "vm/kernel.h" 10 #include "vm/kernel.h"
(...skipping 1468 matching lines...) Expand 10 before | Expand all | Expand 10 after
1479 type->return_type_ = DartType::ReadFrom(reader); 1479 type->return_type_ = DartType::ReadFrom(reader);
1480 return type; 1480 return type;
1481 } 1481 }
1482 1482
1483 1483
1484 TypeParameterType* TypeParameterType::ReadFrom(Reader* reader) { 1484 TypeParameterType* TypeParameterType::ReadFrom(Reader* reader) {
1485 TRACE_READ_OFFSET(); 1485 TRACE_READ_OFFSET();
1486 TypeParameterType* type = new TypeParameterType(); 1486 TypeParameterType* type = new TypeParameterType();
1487 type->parameter_ = 1487 type->parameter_ =
1488 reader->helper()->type_parameters().Lookup(reader->ReadUInt()); 1488 reader->helper()->type_parameters().Lookup(reader->ReadUInt());
1489 // There is an optional promoted bound, currently ignored.
1490 delete reader->ReadOptional<DartType>();
1489 return type; 1491 return type;
1490 } 1492 }
1491 1493
1492 1494
1493 VectorType* VectorType::ReadFrom(Reader* reader) { 1495 VectorType* VectorType::ReadFrom(Reader* reader) {
1494 TRACE_READ_OFFSET(); 1496 TRACE_READ_OFFSET();
1495 VectorType* type = new VectorType(); 1497 VectorType* type = new VectorType();
1496 return type; 1498 return type;
1497 } 1499 }
1498 1500
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 1590
1589 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer, 1591 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer,
1590 intptr_t buffer_length) { 1592 intptr_t buffer_length) {
1591 kernel::Reader reader(buffer, buffer_length); 1593 kernel::Reader reader(buffer, buffer_length);
1592 return kernel::Program::ReadFrom(&reader); 1594 return kernel::Program::ReadFrom(&reader);
1593 } 1595 }
1594 1596
1595 1597
1596 } // namespace dart 1598 } // namespace dart
1597 #endif // !defined(DART_PRECOMPILED_RUNTIME) 1599 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698