Minor clean ups to linux_eclipse_dev.md

docs/linux_eclipse_dev.md

 # Linux Eclipse Dev
 
 Eclipse can be used on Linux (and probably Windows and Mac) as an IDE for
 developing Chromium. It's unpolished, but here's what works:
 
 *   Editing code works well (especially if you're used to it or Visual Studio).
 *   Navigating around the code works well. There are multiple ways to do this
     (F3, control-click, outlines).
 *   Building works fairly well and it does a decent job of parsing errors so
     that you can click and jump to the problem spot.
@@ skipping 47 matching lines @@
 
 Before you start setting up your work space - here are a few hints:
 
 *   Don't put your checkout on a remote file system (e.g. NFS filer). It's too
     slow both for building and for Eclipse.
 *   Make sure there is no file system link in your source path because Ninja
     will resolve it for a faster build and Eclipse / GDB will get confused.
     (Note: This means that the source will possibly not reside in your user
     directory since it would require a link from filer to your local
     repository.)
-*   You may want to start Eclipse from the source root. To do this you can add
-    an icon to your task bar as launcher. It should point to a shell script
-    which will set the current path to your source base, and then start Eclipse.
-    The result would probably look like this:
-
-    ```shell
-    ~/.bashrc
-    cd /usr/local/google/chromium/src
-    export PATH=/home/skuhne/depot_tools:/usr/local/google/goma/goma:/opt/eclipse:/usr/local/symlinks:/usr/local/scripts:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
-    /opt/eclipse/eclipse -vm /usr/bin/java
-    ```
-
-(Note: Things work fine for me without launching Eclipse from a special
-directory. jamescook@chromium.org 2012-06-1)
 
 ### Run Eclipse & Set your workspace
 
 Run eclipse/eclipse in a way that your regular build environment (export CC,
 CXX, etc...) will be visible to the eclipse process.
 
 Set the Workspace to be a directory on a local disk (e.g.
 `/work/workspaces/chrome`).  Placing it on an NFS share is not recommended --
 it's too slow and Eclipse will block on access.  Don't put the workspace in the
 same directory as your checkout.
 
 ### Install the C Development Tools ("CDT")
 
 1.  From the Help menu, select Install New Software...
-    1.  Select the 'Workd with' URL for the CDT
+    1.  Select the 'Work with' URL for the CDT
         If it's not there you can click Add... and add it.
         See https://eclipse.org/cdt/downloads.php for up to date versions,
         e.g. with CDT 8.7.0 for Eclipse Mars, use
         http://download.eclipse.org/tools/cdt/releases/8.7
     1.  Googlers: We have a local mirror, but be sure you run prodaccess before
         trying to use it.
 1.  Select & install the Main and Optional features.
 1.  Restart Eclipse
 1.  Go to Window > Open Perspective > Other... > C/C++ to switch to the C++
     perspective (window layout).
 1.  Right-click on the "Java" perspective in the top-right corner and select
     "Close" to remove it.
 
 ### Create your project(s)
 
 First, turn off automatic workspace refresh and automatic building, as Eclipse
 tries to do these too often and gets confused:
 
 1.  Open Window > Preferences
 1.  Search for "workspace"
 1.  Turn off "Build automatically"
 1.  Turn off "Refresh using native hooks or polling"
 1.  Click "Apply"
 
-Chromium uses C++11, so tell the indexer about it. Otherwise it will get
-confused about things like std::unique_ptr.
-
-1.  Open Window > Preferences > C/C++ > Build > Settings > Discovery >
-    CDT GCC Build-in Compiler Settings
-1.  In the text box entitled Command to get compiler specs append "-std=c++11"
-
 Create a single Eclipse project for everything:
 
 1.  From the File menu, select New > Project...
 1.  Select C/C++ Project > Makefile Project with Existing Code
-1.  Name the project the exact name of the directory: "src"
-1.  Provide a path to the code, like /work/chromium/src
+1.  Name the project the exact name of the directory: "src" (or "WebKit" if you
+    mainly work in Blink and want a faster experience)
+1.  Provide a path to the code, like /work/chromium/src (or
+    /work/chromium/src/third_party/WebKit)
 1.  Select toolchain: Linux GCC
 1.  Click Finish.
 
+Chromium uses C++11, so tell the indexer about it. Otherwise it will get
+confused about things like std::unique_ptr.
+
+1.  Right-click on "src" and select "Properties..."
+1.  Navigate to C/C++ General > Preprocess Include Paths, Macros etc. >
+    Providers
+1.  Select CDT GCC Built-in Compiler Settings
+1.  In the text box entitled Command to get compiler specs append "-std=c++11"
+    (leaving out the quotes)
+
 Chromium has a huge amount of code, enough that Eclipse can take a very long
 time to perform operations like "go to definition" and "open resource". You need
 to set it up to operate on a subset of the code.
 
 In the Project Explorer on the left side:
 
 1.  Right-click on "src" and select "Properties..."
 1.  Open Resource > Resource Filters
-1.  Click "Add..."
+1.  Click "Add Filter..."
 1.  Add the following filter:
     *   Include only
     *   Files, all children (recursive)
     *   Name matches
         `.*\.(c|cc|cpp|h|mm|inl|idl|js|json|css|html|gyp|gypi|grd|grdp|gn|gni|mojom)`
         regular expression
 1.  Add another filter:
     *   Exclude all
     *   Folders
-    *   Name matches `out_.*|\.git|\.svn|LayoutTests` regular expression
+    *   Name matches `out_.*|\.git|LayoutTests` regular expression
         *   If you aren't working on WebKit, adding `|WebKit` will remove more
             files
-1.  Click "OK"
+1.  Click "Apply and Close"
 
 Don't exclude the primary "out" directory, as it contains generated header files
 for things like string resources and Eclipse will miss a lot of symbols if you
 do.
 
 Eclipse will refresh the workspace and start indexing your code. It won't find
 most header files, however. Give it more help finding them:
 
 1.  Open Window > Preferences
 1.  Search for "Indexer"
 1.  Turn on "Allow heuristic resolution of includes"
 1.  Select "Use active build configuration"
 1.  Set Cache limits > Index database > Limit relative... to 20%
 1.  Set Cache limits > Index database > Absolute limit to 256 MB
-1.  Click "OK"
+1.  Click "Apply and Close"
 
 Now the indexer will find many more include files, regardless of which approach
 you take below.
 
 #### Optional: Manual header paths and symbols
 
 You can manually tell Eclipse where to find header files, which will allow it to
 create the source code index before you do a real build.
 
 1.  Right-click on "src" and select "Properties..."
@@ skipping 97 matching lines @@
 ### Optional: Accurate symbol information
 
 If setup properly, Eclipse can do a great job of semantic navigation of C++ code
 (showing type hierarchies, finding all references to a particular method even
 when other classes have methods of the same name, etc.). But doing this well
 requires the Eclipse knows correct include paths and pre-processor definitions.
 After fighting with with a number of approaches, I've found the below to work
 best for me.
 
 1.  From a shell in your src directory, run
-    `gn gen --ide=eclipse out/Debug_gn/' (replacing Debug_gn with the output directory you normally use when building).
-    1.  This generates <project root>/out/Debug_gn/eclipse-cdt-settings.xml which
+    `gn gen --ide=eclipse out/Debug/` (replacing Debug with the output directory you normally use when building).
+    1.  This generates <project root>/out/Debug/eclipse-cdt-settings.xml which
         is used below.
     1.  This creates a single list of include directories and preprocessor
         definitions to be used for all source files, and so is a little
         inaccurate. Here are some tips for compensating for the limitations:
         1.  If you care about blink, move 'third\_party/WebKit/Source' to the
             top of the list to better resolve ambiguous include paths (eg.
             `config.h`).
 1.  Import paths and symbols
     1.  Right click on the project and select Properties > C/C++ General > Paths
         and Symbols
@@ skipping 90 matching lines @@
     sure the editor is not maximized inside Eclipse, i.e. you should see more
     subwindows around.
 
 ### Additional tips
 
 1.  Mozilla's
     [Eclipse CDT guide](https://developer.mozilla.org/en-US/docs/Eclipse_CDT)
     is helpful:
 1.  For improved performance, I use medium-granularity projects (eg. one for
     WebKit/Source) instead of putting all of 'src/' in one project.
-1.  For working in Blink (which uses WebKit code style), feel free to use
-    [this](https://drive.google.com/file/d/0B2LVVIKSxUVYM3R6U0tUa1dmY0U/view?usp=sharing)
-    code-style formatter XML profile