tools/metrics/histograms/update_histogram_enum.py - Issue 2866573002: Minor fix UpdateHistogramEnum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/update_histogram_enum.py

Issue 2866573002: Minor fix UpdateHistogramEnum (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/update_histogram_enum.py

diff --git a/tools/metrics/histograms/update_histogram_enum.py b/tools/metrics/histograms/update_histogram_enum.py

index 522af7f5ec9b6e191da1026a2dec15ab2b49aed8..f8fa1cfcc98f31cea6250e279783daceeda5985b 100644

--- a/tools/metrics/histograms/update_histogram_enum.py

+++ b/tools/metrics/histograms/update_histogram_enum.py

@@ -274,7 +274,7 @@ def UpdateHistogramEnum(histogram_enum_name, source_enum_path,

"""

Log('Reading histogram enum definition from "{0}".'.format(source_enum_path))

- source_enum_values, ignored = ReadHistogramValues(source_enum_path,

+ source_enum_values = ReadHistogramValues(source_enum_path,

start_marker, end_marker, strip_k_prefix)

UpdateHistogramFromDict(histogram_enum_name, source_enum_values,

« no previous file with comments | « no previous file | no next file » | no next file with comments »