Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2866553002: Update status files: these co19 tests seemed to have invalid code that got (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status files: these co19 tests seemed to have invalid code that got "fixed" by the changes to void. For example, they return a value on a void function, and then read it. Probably the tests need to be fixed. For now I'm updating the status files to make the bots green. BUG= https://github.com/dart-lang/sdk/issues/29565 Committed: https://github.com/dart-lang/sdk/commit/dadb76a197b0b5c8493d6b63a423fd743fa0c6cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tests/co19/co19-dart2js.status View 5 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-04 22:12:22 UTC) #4
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-04 22:12:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
dadb76a197b0b5c8493d6b63a423fd743fa0c6cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698