Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2866543002: Implement instantiateToBounds in front_end. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement instantiateToBounds in front_end. R=scheglov@google.com Note: error reporting will be added in a follow-up CL. Committed: https://github.com/dart-lang/sdk/commit/c376a45f91f28217508d926fe3d9c34d762c2709

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 2 chunks +59 lines, -0 lines 2 comments Download
M pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
3 years, 7 months ago (2017-05-04 22:00:39 UTC) #3
scheglov
LGTM https://codereview.chromium.org/2866543002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2866543002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode177 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:177: type = Substitution.fromMap(knownTypes).substituteType(type); There is some asymmetry here. ...
3 years, 7 months ago (2017-05-04 22:09:21 UTC) #4
Paul Berry
https://codereview.chromium.org/2866543002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart File pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart (right): https://codereview.chromium.org/2866543002/diff/1/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart#newcode177 pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart:177: type = Substitution.fromMap(knownTypes).substituteType(type); On 2017/05/04 22:09:20, scheglov wrote: > ...
3 years, 7 months ago (2017-05-04 22:14:04 UTC) #5
Paul Berry
3 years, 7 months ago (2017-05-04 22:23:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c376a45f91f28217508d926fe3d9c34d762c2709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698