Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2349)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.js

Issue 2866463002: Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 8c1fba402731179be2c970afd58a700c4fbf643e..122f10a9f681dec320072f202d7c6b19358c557e 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -18,10 +18,12 @@
},
/**
- * Dictionary defining page visibility. Controlled by settings-ui.
- * @type {!PageVisibility|undefined}
+ * Dictionary defining page visibility.
+ * @type {!GuestModePageVisibility}
*/
- pageVisibility: Object,
+ pageVisibility: {
+ type: Object,
+ },
},
listeners: {
@@ -43,15 +45,6 @@
}
this.setSelectedUrl_(''); // Nothing is selected.
- },
-
- /**
- * @param {boolean|undefined} visibility
- * @return {boolean}
- * @private
- */
- showPage_: function(visibility) {
- return visibility !== false;
},
/**

Powered by Google App Engine
This is Rietveld 408576698