Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2866463002: Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for settings-languages-page. */ 5 /** @fileoverview Suite of tests for settings-languages-page. */
6 6
7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */ 7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
8 var ROOT_PATH = '../../../../../'; 8 var ROOT_PATH = '../../../../../';
9 9
10 // Polymer BrowserTest fixture. 10 // Polymer BrowserTest fixture.
11 GEN_INCLUDE( 11 GEN_INCLUDE(
12 [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']); 12 [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']);
13 // SettingsPageBrowserTest fixture. 13 // SettingsPageBrowserTest fixture.
14 GEN_INCLUDE([ROOT_PATH + 14 GEN_INCLUDE([ROOT_PATH +
15 'chrome/test/data/webui/settings/settings_page_browsertest.js']); 15 'chrome/test/data/webui/settings/settings_page_browsertest.js']);
16 16
17 /** 17 /**
18 * Test class for settings-languages-page UI. 18 * Test class for settings-languages-page UI.
19 * @constructor 19 * @constructor
20 * @extends {SettingsPageBrowserTest} 20 * @extends {SettingsPageBrowserTest}
21 */ 21 */
22 function SettingsLanguagesPageBrowserTest() {} 22 function SettingsLanguagesPageBrowserTest() {}
23 23
24 SettingsLanguagesPageBrowserTest.prototype = { 24 SettingsLanguagesPageBrowserTest.prototype = {
25 __proto__: SettingsPageBrowserTest.prototype, 25 __proto__: SettingsPageBrowserTest.prototype,
26 26
27 /** @override */ 27 /** @override */
28 preLoad: function() { 28 preLoad: function() {
29 SettingsPageBrowserTest.prototype.preLoad.call(this); 29 SettingsPageBrowserTest.prototype.preLoad.call(this);
30 settingsHidePagesByDefaultForTest = true;
30 }, 31 },
31 }; 32 };
32 33
33 // Flaky on Windows, Mac and Linux. See https://crbug.com/641400. 34 // Flaky on Windows, Mac and Linux. See https://crbug.com/641400.
34 // 35 //
35 // May time out on debug builders and memory bots because the Settings page can 36 // May time out on debug builders and memory bots because the Settings page can
36 // take several seconds to load in a Release build and several times that in a 37 // take several seconds to load in a Release build and several times that in a
37 // Debug build. See https://crbug.com/558434. 38 // Debug build. See https://crbug.com/558434.
38 // 39 //
39 // Disabling this test in general. 40 // Disabling this test in general.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 } 76 }
76 77
77 // Returns supported languages that are not enabled. 78 // Returns supported languages that are not enabled.
78 function getAvailableLanguages() { 79 function getAvailableLanguages() {
79 return languagesPage.languages.supported.filter(function(language) { 80 return languagesPage.languages.supported.filter(function(language) {
80 return !languageHelper.isLanguageEnabled(language.code); 81 return !languageHelper.isLanguageEnabled(language.code);
81 }); 82 });
82 } 83 }
83 84
84 suiteSetup(function() { 85 suiteSetup(function() {
85 languagesSection = assert(this.getSection(self.basicPage, 'languages')); 86 var page = self.basicPage;
87 page.set('pageVisibility.languages', true);
88 Polymer.dom.flush();
89
90 languagesSection = assert(this.getSection(page, 'languages'));
86 languagesPage = assert( 91 languagesPage = assert(
87 languagesSection.querySelector('settings-languages-page')); 92 languagesSection.querySelector('settings-languages-page'));
88 languagesCollapse = languagesPage.$.languagesCollapse; 93 languagesCollapse = languagesPage.$.languagesCollapse;
89 languagesCollapse.opened = true; 94 languagesCollapse.opened = true;
90 actionMenu = languagesPage.$.menu.get(); 95 actionMenu = languagesPage.$.menu.get();
91 96
92 languageHelper = languagesPage.languageHelper; 97 languageHelper = languagesPage.languageHelper;
93 return languageHelper.whenReady(); 98 return languageHelper.whenReady();
94 }.bind(this)); 99 }.bind(this));
95 100
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 0, triggerRow.querySelector('.secondary').textContent.length); 452 0, triggerRow.querySelector('.secondary').textContent.length);
448 } 453 }
449 }); 454 });
450 }.bind(this)); 455 }.bind(this));
451 456
452 // TODO(michaelpg): Test more aspects of the languages UI. 457 // TODO(michaelpg): Test more aspects of the languages UI.
453 458
454 // Run all registered tests. 459 // Run all registered tests.
455 mocha.run(); 460 mocha.run();
456 }); 461 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698