Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility

chrome/browser/resources/settings/settings_ui/settings_ui.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-ui' implements the UI for the Settings page.
  *
  * Example:
  *
@@ skipping 30 matching lines @@
       notify: true,
     },
 
     /** @private {boolean} */
     toolbarSpinnerActive_: {
       type: Boolean,
       value: false,
     },
 
     /**
-     * Dictionary defining page visibility. Pages are hidden when their entry
-     * is set to *false*. i.e. visibility defaults to true.
-     * @private {!PageVisibility}
+     * Dictionary defining page visibility.
+     * This is only set when in guest mode. All pages are visible when not set
+     * because polymer only notifies after a property is set.
+     * @private {!GuestModePageVisibility}
      */
-    pageVisibility_: {
-      type: Object,
-      value: function() {
-        return {};
-      },
-    },
+    pageVisibility_: Object,
+
+    /** @private */
+    showAndroidApps_: Boolean,
 
     /** @private */
     lastSearchQuery_: {
       type: String,
       value: '',
     }
   },
 
   listeners: {
     'refresh-pref': 'onRefreshPref_',
@@ skipping 79 matching lines @@
           searchPrediction: false,
           networkPrediction: false,
         },
         downloads: {
           googleDrive: false,
         },
 // </if>
       };
     }
 
-// <if expr="chromeos">
-    this.pageVisibility_.androidApps =
-        loadTimeData.valueExists('androidAppsAllowed') &&
+    this.showAndroidApps_ = loadTimeData.valueExists('androidAppsAllowed') &&
         loadTimeData.getBoolean('androidAppsAllowed');
-// </if>
   },
 
   /** @private {?IntersectionObserver} */
   intersectionObserver_: null,
 
   /** @override */
   attached: function() {
     document.documentElement.classList.remove('loading');
 
     setTimeout(function() {
@@ skipping 105 matching lines @@
       this.$.container.removeAttribute('tabindex');
     }.bind(this));
   },
 
   /** @private */
   directionDelegateChanged_: function() {
     this.$.drawer.align = this.directionDelegate.isRtl() ?
         'right' : 'left';
   },
 });