Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility

chrome/browser/resources/settings/settings_menu/settings_menu.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-menu' shows a menu with a hardcoded set of pages and subpages.
  */
 Polymer({
   is: 'settings-menu',
 
   behaviors: [settings.RouteObserverBehavior],
 
   properties: {
     advancedOpened: {
       type: Boolean,
       notify: true,
     },
 
     /**
-     * Dictionary defining page visibility. Controlled by settings-ui.
-     * @type {!PageVisibility|undefined}
+     * Dictionary defining page visibility.
+     * @type {!GuestModePageVisibility}
      */
-    pageVisibility: Object,
+    pageVisibility: {
+      type: Object,
+    },
   },
 
   listeners: {
     'topMenu.tap': 'onLinkTap_',
     'subMenu.tap': 'onLinkTap_',
   },
 
   /** @param {!settings.Route} newRoute */
   currentRouteChanged: function(newRoute) {
     var currentPath = newRoute.path;
 
     // Focus the initially selected path.
     var anchors = this.root.querySelectorAll('a');
     for (var i = 0; i < anchors.length; ++i) {
       if (anchors[i].getAttribute('href') == currentPath) {
         this.setSelectedUrl_(anchors[i].href);
         return;
       }
     }
 
     this.setSelectedUrl_('');  // Nothing is selected.
   },
 
   /**
-   * @param {boolean|undefined} visibility
-   * @return {boolean}
-   * @private
-   */
-  showPage_: function(visibility) {
-    return visibility !== false;
-  },
-
-  /**
    * Prevent clicks on sidebar items from navigating. These are only links for
    * accessibility purposes, taps are handled separately by <iron-selector>.
    * @param {!Event} event
    * @private
    */
   onLinkTap_: function(event) {
     if (event.target.hasAttribute('href'))
       event.preventDefault();
   },
 
@@ skipping 22 matching lines @@
 
   /**
    * @param {boolean} opened Whether the menu is expanded.
    * @return {string} Which icon to use.
    * @private
    * */
   arrowState_: function(opened) {
     return opened ? 'cr:arrow-drop-up' : 'cr:arrow-drop-down';
   },
 });