Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2866363004: Fix annotation of generic method invocations in Fasta inference tests (again). (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix annotation of generic method invocations in Fasta inference tests (again). In c8026439dc59f3d22ba7f6af074b9cf9e6819ab0, I was overzealous and annotated all generic method invocation parameters, whether they were inferred or explicit. We just want to annotate the inferred ones. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/22f68e645044a86465cf6881df938f84b25485ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +9 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_then_explicit_future.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_method_type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_instance_method_identifier_sequence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_static_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_top_level_function.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-10 17:17:08 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 17:18:13 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-10 17:21:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22f68e645044a86465cf6881df938f84b25485ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698