content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java - Issue 2866253002: Refactor NetworkChangeNotifierAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java

Issue 2866253002: Refactor NetworkChangeNotifierAndroid (Closed)

Patch Set: Add test to make sure NCN doesn't call native functions during startup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java ('k') | net/android/BUILD.gn » ('j') | net/android/javatests/src/org/chromium/net/NetworkChangeNotifierNoNativeTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java b/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java

index b13802a7abaf875b7e57efb520ddf82584674429..997d05a18670c55bbad4b4632558f010fb294df4 100644

--- a/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java

+++ b/content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java

@@ -86,8 +86,7 @@ class BackgroundSyncNetworkObserver implements NetworkChangeNotifierAutoDetect.O

mNativePtrs.add(nativePtr);

nativeNotifyConnectionTypeChanged(

- nativePtr, NetworkChangeNotifierAutoDetect.convertToConnectionType(

- mNotifier.getCurrentNetworkState()));

+ nativePtr, mNotifier.getCurrentNetworkState().getConnectionType());

}

@CalledByNative

@@ -110,7 +109,7 @@ class BackgroundSyncNetworkObserver implements NetworkChangeNotifierAutoDetect.O

}

@Override

- public void onMaxBandwidthChanged(double maxBandwidthMbps) {}

+ public void onConnectionSubtypeChanged(int newConnectionSubtype) {}

@Override

public void onNetworkConnect(long netId, int connectionType) {}

@Override