[turbofan] Don't mix element accesses with incompatible representations.

src/compiler/load-elimination.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_LOAD_ELIMINATION_H_
 #define V8_COMPILER_LOAD_ELIMINATION_H_
 
 #include "src/base/compiler-specific.h"
 #include "src/compiler/graph-reducer.h"
 #include "src/globals.h"
+#include "src/machine-type.h"
 #include "src/zone/zone-handle-set.h"
 
 namespace v8 {
 namespace internal {
 
 // Forward declarations.
 class Factory;
 
 namespace compiler {
 
@@ skipping 50 matching lines @@
 
   // Abstract state to approximate the current state of an element along the
   // effect paths through the graph.
   class AbstractElements final : public ZoneObject {
    public:
     explicit AbstractElements(Zone* zone) {
       for (size_t i = 0; i < arraysize(elements_); ++i) {
         elements_[i] = Element();
       }
     }
-    AbstractElements(Node* object, Node* index, Node* value, Zone* zone)
+    AbstractElements(Node* object, Node* index, Node* value,
+                     MachineRepresentation representation, Zone* zone)
         : AbstractElements(zone) {
-      elements_[next_index_++] = Element(object, index, value);
+      elements_[next_index_++] = Element(object, index, value, representation);
     }
 
     AbstractElements const* Extend(Node* object, Node* index, Node* value,
+                                   MachineRepresentation representation,
                                    Zone* zone) const {
       AbstractElements* that = new (zone) AbstractElements(*this);
-      that->elements_[that->next_index_] = Element(object, index, value);
+      that->elements_[that->next_index_] =
+          Element(object, index, value, representation);
       that->next_index_ = (that->next_index_ + 1) % arraysize(elements_);
       return that;
     }
-    Node* Lookup(Node* object, Node* index) const;
+    Node* Lookup(Node* object, Node* index,
+                 MachineRepresentation representation) const;
     AbstractElements const* Kill(Node* object, Node* index, Zone* zone) const;
     bool Equals(AbstractElements const* that) const;
     AbstractElements const* Merge(AbstractElements const* that,
                                   Zone* zone) const;
 
     void Print() const;
 
    private:
     struct Element {
       Element() {}
-      Element(Node* object, Node* index, Node* value)
-          : object(object), index(index), value(value) {}
+      Element(Node* object, Node* index, Node* value,
+              MachineRepresentation representation)
+          : object(object),
+            index(index),
+            value(value),
+            representation(representation) {}
 
       Node* object = nullptr;
       Node* index = nullptr;
       Node* value = nullptr;
+      MachineRepresentation representation = MachineRepresentation::kNone;
     };
 
     Element elements_[kMaxTrackedElements];
     size_t next_index_ = 0;
   };
 
   // Abstract state to approximate the current state of a certain field along
   // the effect paths through the graph.
   class AbstractField final : public ZoneObject {
    public:
@@ skipping 97 matching lines @@
     bool LookupMaps(Node* object, ZoneHandleSet<Map>* object_maps) const;
 
     AbstractState const* AddField(Node* object, size_t index, Node* value,
                                   Zone* zone) const;
     AbstractState const* KillField(Node* object, size_t index,
                                    Zone* zone) const;
     AbstractState const* KillFields(Node* object, Zone* zone) const;
     Node* LookupField(Node* object, size_t index) const;
 
     AbstractState const* AddElement(Node* object, Node* index, Node* value,
+                                    MachineRepresentation representation,
                                     Zone* zone) const;
     AbstractState const* KillElement(Node* object, Node* index,
                                      Zone* zone) const;
-    Node* LookupElement(Node* object, Node* index) const;
+    Node* LookupElement(Node* object, Node* index,
+                        MachineRepresentation representation) const;
 
     AbstractState const* AddCheck(Node* node, Zone* zone) const;
     Node* LookupCheck(Node* node) const;
 
     void Print() const;
 
    private:
     AbstractChecks const* checks_ = nullptr;
     AbstractElements const* elements_ = nullptr;
     AbstractField const* fields_[kMaxTrackedFields];
@@ skipping 46 matching lines @@
   JSGraph* const jsgraph_;
 
   DISALLOW_COPY_AND_ASSIGN(LoadElimination);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_LOAD_ELIMINATION_H_