components/favicon/core/large_icon_service.h - Issue 2866033002: [NTP Tiles] Fetch missing MostLikely tiles from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/large_icon_service.h

Issue 2866033002: [NTP Tiles] Fetch missing MostLikely tiles from a Google server (Closed)

Patch Set: Comments #3 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/large_icon_service.h

diff --git a/components/favicon/core/large_icon_service.h b/components/favicon/core/large_icon_service.h

index bfea67603d6baabd939a553b363033c0857b1de3..d07888a044cf785f55589040f29783effef229d8 100644

--- a/components/favicon/core/large_icon_service.h

+++ b/components/favicon/core/large_icon_service.h

@@ -82,6 +82,8 @@ class LargeIconService : public KeyedService {

// WARNING: This function will share the |page_url| with a Google server. This

// Can be used only for urls that are not privacy sensitive or for users that

// sync their history with Google servers.

+ // TODO(jkrcal): It is not clear from the name of this function, that it

+ // actually adds the icon to the local cache. Maybe "StoreLargeIcon..."?

void GetLargeIconOrFallbackStyleFromGoogleServerSkippingLocalCache(

const GURL& page_url,

int min_source_size_in_pixel,