Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2866033002: [NTP Tiles] Fetch missing MostLikely tiles from a Google server (Closed)
Patch Set: Finishing unit-tests and comments #1 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index 6809aa4dcbd236a2b3f1df557907b409b03c50b9..229c74db7d9b285134f465f8cbdd3d0bf929163b 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -268,6 +268,11 @@ void MostVisitedSites::BuildCurrentTilesGivenSuggestionsProfile(
tile.whitelist_icon_path = GetWhitelistLargeIconPath(url);
tile.thumbnail_url = GURL(suggestion_pb.thumbnail());
tile.favicon_url = GURL(suggestion_pb.favicon_url());
+ if (AreNtpMostLikelyFaviconsFromServerEnabled()) {
+ icon_cacher_->StartFetchMostLikely(
+ url, base::Bind(&MostVisitedSites::OnIconMadeAvailable,
+ base::Unretained(this), url));
+ }
tiles.push_back(std::move(tile));
}
@@ -360,7 +365,8 @@ NTPTilesVector MostVisitedSites::CreatePopularSitesTiles(
base::Closure icon_available =
base::Bind(&MostVisitedSites::OnIconMadeAvailable,
base::Unretained(this), popular_site.url);
- icon_cacher_->StartFetch(popular_site, icon_available, icon_available);
+ icon_cacher_->StartFetchPopularSites(popular_site, icon_available,
+ icon_available);
if (popular_sites_tiles.size() >= num_popular_sites_tiles)
break;
}
@@ -422,7 +428,8 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {
for (const PopularSites::Site& popular_site : popular_sites_->sites()) {
// Ignore callback; these icons will be seen on the *next* NTP.
- icon_cacher_->StartFetch(popular_site, base::Closure(), base::Closure());
+ icon_cacher_->StartFetchPopularSites(popular_site, base::Closure(),
+ base::Closure());
}
}

Powered by Google App Engine
This is Rietveld 408576698