[NTP Tiles] Fetch missing MostLikely tiles from a Google server

components/favicon_base/favicon_types.cc

Index: components/favicon_base/favicon_types.cc
diff --git a/components/favicon_base/favicon_types.cc b/components/favicon_base/favicon_types.cc
index b03f0ecd4ae4330ef4bc176c0e7d31945c272ea9..9966977e6fedf9035955846177d0bd4aca6d7b66 100644
--- a/components/favicon_base/favicon_types.cc
+++ b/components/favicon_base/favicon_types.cc
@@ -38,6 +38,12 @@ LargeIconResult::LargeIconResult(FallbackIconStyle* fallback_icon_style_in)
 
 LargeIconResult::~LargeIconResult() {}
 
+bool LargeIconResult::is_empty() const {
+  return !bitmap.is_valid() &&
+         (!fallback_icon_style ||
+          fallback_icon_style->is_default_background_color);

[sfiera, 2017/05/09 08:53:36]

I find this condition hard to read. What about:

  if (bitmap.is_valid())
    return false;
  if (fallback is valid)
    return false;
  return true;

[pkotwicz, 2017/05/09 17:40:34]

It would be nice if FallbackIconStyle had a FallbackIconStyle::IsDefault()
method.

Implementing FallbackIconStyle::IsDefault() will be simpler once
crbug.com/712475 is addressed. I have started addressing crbug.com/712475 (super
easy to do :) ). I am currently blocked on hearing from treib@ as to whether
instant uses chrome-search://large-icon or chrome-search://fallback-icon

[jkrcal, 2017/05/10 17:26:03]

So far, I went for the suggestion of sfiera@.
Can we please keep your proposal for a follow-up CL? 
(such as the one that introduces IsDefault())

[jkrcal, 2017/05/10 17:26:03]

Done.

+}
+
 // --------------------------------------------------------
 // LargeIconImageResult