SuggestionsService: don't automatically fetch on startup

components/suggestions/suggestions_service_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/suggestions/suggestions_service_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
@@ skipping 289 matching lines @@
       .Times(AnyNumber())
       .WillRepeatedly(Return(syncer::ModelTypeSet(
           syncer::HISTORY_DELETE_DIRECTIVES, syncer::BOOKMARKS)));
   EXPECT_CALL(callback, Run(_)).Times(0);
   suggestions_service_->OnStateChanged(&mock_sync_service_);
 
   // Let any network request run (there shouldn't be one).
   base::RunLoop().RunUntilIdle();
 }
 
+// During startup, the state changes from NOT_INITIALIZED_ENABLED to
+// INITIALIZED_ENABLED_HISTORY (for a signed-in user with history sync enabled).
+// This should *not* result in an automatic fetch.
+TEST_F(SuggestionsServiceTest, DoesNotFetchOnStartup) {
+  // The sync service starts out inactive.
+  EXPECT_CALL(mock_sync_service_, IsSyncActive()).WillRepeatedly(Return(false));
+  suggestions_service_->OnStateChanged(&mock_sync_service_);
+
+  ASSERT_EQ(SuggestionsServiceImpl::NOT_INITIALIZED_ENABLED,
+            suggestions_service_->ComputeSyncState());
+
+  base::MockCallback<SuggestionsService::ResponseCallback> callback;
+  auto subscription = suggestions_service_->AddCallback(callback.Get());
+
+  factory_.SetFakeResponse(SuggestionsServiceImpl::BuildSuggestionsURL(),
+                           CreateSuggestionsProfile().SerializeAsString(),
+                           net::HTTP_OK, net::URLRequestStatus::SUCCESS);
+
+  // Sync getting enabled should not result in a fetch.
+  EXPECT_CALL(mock_sync_service_, IsSyncActive()).WillRepeatedly(Return(true));
+  EXPECT_CALL(callback, Run(_)).Times(0);

[mastiz, 2017/05/08 14:18:32]

I should've mentioned this earlier (as part of the StrictMock discussion), but
what you probably want is to move this expectation immediately after the
callback is instantiated. Right now the callback could've been called within
AddCallback() and the test would pass.

[Marc Treib, 2017/05/08 14:57:46]

Done.

+  suggestions_service_->OnStateChanged(&mock_sync_service_);
+
+  ASSERT_EQ(SuggestionsServiceImpl::INITIALIZED_ENABLED_HISTORY,
+            suggestions_service_->ComputeSyncState());
+
+  // Let any network request run (there shouldn't be one).
+  base::RunLoop().RunUntilIdle();
+}
+
 TEST_F(SuggestionsServiceTest, FetchSuggestionsDataSyncNotInitializedEnabled) {
   EXPECT_CALL(mock_sync_service_, IsSyncActive()).WillRepeatedly(Return(false));
   suggestions_service_->OnStateChanged(&mock_sync_service_);
 
   base::MockCallback<SuggestionsService::ResponseCallback> callback;
   auto subscription = suggestions_service_->AddCallback(callback.Get());
 
   // Try to fetch suggestions. Since sync is not active, no network request
   // should be sent.
   EXPECT_CALL(callback, Run(_)).Times(0);
@@ skipping 384 matching lines @@
   EXPECT_CALL(*mock_thumbnail_manager_, GetImageForURL(test_url, _));
   suggestions_service_->GetPageThumbnail(test_url, dummy_callback);
 
   EXPECT_CALL(*mock_thumbnail_manager_, AddImageURL(test_url, thumbnail_url));
   EXPECT_CALL(*mock_thumbnail_manager_, GetImageForURL(test_url, _));
   suggestions_service_->GetPageThumbnailWithURL(test_url, thumbnail_url,
                                                 dummy_callback);
 }
 
 }  // namespace suggestions