Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 2866011: Don't need to copy the challenge data before calling DER_Encode because... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by wtc
Modified:
3 years, 11 months ago
Reviewers:
David Benjamin, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Don't need to copy the challenge data before calling DER_Encode because DER_Encode will copy it. Document the GenKeyAndSignChallenge function. R=mattm,davidben BUG=148 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50682

Patch Set 1 #

Patch Set 2 : Add a necessary typecast. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M net/third_party/mozilla_security_manager/nsKeygenHandler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 1 3 chunks +2 lines, -10 lines 1 comment Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
wtc
mattm: please review this CL. davidben: these are the only minor issues I found while ...
4 years, 10 months ago (2010-06-18 18:20:33 UTC) #1
wtc
Some notes: http://codereview.chromium.org/2866011/diff/4001/5001 File net/third_party/mozilla_security_manager/nsKeygenHandler.cpp (right): http://codereview.chromium.org/2866011/diff/4001/5001#newcode212 net/third_party/mozilla_security_manager/nsKeygenHandler.cpp:212: pkac.challenge.data = (unsigned char *)challenge.data(); DER_Encode does ...
4 years, 10 months ago (2010-06-18 18:26:27 UTC) #2
mattm
LGTM
4 years, 10 months ago (2010-06-18 19:03:58 UTC) #3
David Benjamin
4 years, 10 months ago (2010-06-18 20:55:50 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 700cc9d