Chromium Code Reviews
Help | Chromium Project | Sign in
(92)

Issue 2866008: [Isolates] Move contents of Top into Isolate.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by zarko
Modified:
2 years, 11 months ago
Reviewers:
Maxim.Mossienko, maxim.mossienko, Vitaly Repeshko, Dmitry Titov
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

[Isolates] Move contents of Top into Isolate.

- Interesting changes are in top.cc, isolate.cc, isolate.h.
- Other changes are textual replacement of Top:: with
Isolate::Current()->.
- The code in top.cc belongs in isolate.cc, but we'll leave it where it is
to make merging easier.


Committed: http://code.google.com/p/v8/source/detail?r=4907

Patch Set 1 #

Patch Set 2 : lints #

Total comments: 2

Patch Set 3 : reuse some isolate pointers #

Patch Set 4 : reuse some isolate pointers #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : integrate patch from vitalyr to move handle out of isolate.h #

Patch Set 8 : fix includes in isolate.h #

Patch Set 9 : initialize stack guard properly #

Patch Set 10 : '' #

Patch Set 11 : a fix that makes sense #

Patch Set 12 : '' #

Total comments: 4

Patch Set 13 : cleanup post-apply.js #

Patch Set 14 : rebase #

Patch Set 15 : rebase fixes #

Patch Set 16 : ensure we're synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1369 lines, -1325 lines) Lint Patch
M include/v8.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M src/accessors.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +7 lines, -7 lines 0 comments 0 errors Download
M src/api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 22 chunks +34 lines, -30 lines 0 comments 0 errors Download
M src/arm/codegen-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 chunks +16 lines, -14 lines 0 comments 0 errors Download
M src/arm/frames-arm.h View 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +7 lines, -7 lines 0 comments 0 errors Download
M src/arm/regexp-macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/arm/stub-cache-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/assembler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -2 lines 0 comments 0 errors Download
M src/assembler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 18 chunks +43 lines, -36 lines 0 comments 0 errors Download
M src/builtins.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +10 lines, -9 lines 0 comments 0 errors Download
M src/checks.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -2 lines 0 comments 0 errors Download
M src/codegen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/compiler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +7 lines, -7 lines 0 comments 0 errors Download
M src/contexts.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -8 lines 0 comments 0 errors Download
M src/debug.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/debug.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +19 lines, -16 lines 0 comments 0 errors Download
M src/execution.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 13 chunks +36 lines, -29 lines 0 comments ? errors Download
M src/factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +14 lines, -11 lines 0 comments ? errors Download
M src/fast-codegen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/frames.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments ? errors Download
M src/frames.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +7 lines, -5 lines 0 comments ? errors Download
M src/full-codegen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/handles.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -38 lines 0 comments ? errors Download
M src/handles.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +12 lines, -8 lines 0 comments ? errors Download
M src/handles-inl.h View 7 8 9 10 11 12 13 2 chunks +50 lines, -1 line 0 comments ? errors Download
M src/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 8 chunks +8 lines, -8 lines 0 comments ? errors Download
M src/ia32/codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 12 chunks +18 lines, -14 lines 0 comments ? errors Download
M src/ia32/fast-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/ia32/frames-ia32.h View 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +8 lines, -7 lines 0 comments ? errors Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments ? errors Download
M src/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -3 lines 0 comments ? errors Download
M src/isolate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +360 lines, -5 lines 0 comments ? errors Download
M src/isolate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +178 lines, -2 lines 0 comments ? errors Download
M src/jsregexp.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +7 lines, -8 lines 0 comments ? errors Download
M src/liveedit.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +9 lines, -7 lines 0 comments ? errors Download
M src/log.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/messages.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -4 lines 0 comments ? errors Download
M src/messages.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/mips/codegen-mips.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +8 lines, -6 lines 0 comments ? errors Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +6 lines, -6 lines 0 comments ? errors Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 33 chunks +57 lines, -49 lines 0 comments ? errors Download
M src/parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +5 lines, -5 lines 0 comments ? errors Download
M src/platform-linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -3 lines 0 comments ? errors Download
M src/profile-generator.cc View 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/regexp-macro-assembler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M src/regexp-stack.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -1 line 0 comments ? errors Download
M src/runtime.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 76 chunks +117 lines, -102 lines 0 comments ? errors Download
M src/serialize.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -6 lines 0 comments ? errors Download
M src/stub-cache.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
D src/top.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -383 lines 0 comments ? errors Download
M src/top.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 34 chunks +154 lines, -339 lines 0 comments ? errors Download
M src/v8.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -19 lines 0 comments ? errors Download
M src/v8threads.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +9 lines, -9 lines 0 comments ? errors Download
M src/x64/codegen-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 12 chunks +17 lines, -14 lines 0 comments ? errors Download
M src/x64/frames-x64.h View 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +6 lines, -6 lines 0 comments ? errors Download
M src/x64/regexp-macro-assembler-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/x64/stub-cache-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments ? errors Download
M test/cctest/test-alloc.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +4 lines, -4 lines 0 comments ? errors Download
M test/cctest/test-compiler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 11 chunks +13 lines, -14 lines 0 comments ? errors Download
M test/cctest/test-debug.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/cctest/test-disasm-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M test/cctest/test-heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +23 lines, -13 lines 0 comments ? errors Download
M test/cctest/test-log-stack-tracer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +9 lines, -8 lines 0 comments ? errors Download
M test/cctest/test-mark-compact.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +13 lines, -9 lines 0 comments ? errors Download
M test/cctest/test-regexp.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M test/cctest/test-serialize.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 5
zarko
http://codereview.chromium.org/2866008/diff/5002/26016 File src/contexts.h (right): http://codereview.chromium.org/2866008/diff/5002/26016#newcode263 src/contexts.h:263: inline bool has_out_of_memory(); Moved the implementation of these to ...
3 years, 10 months ago #1
zarko
Thanks Luke
3 years, 10 months ago #2
Maxim.Mossienko
Drive by comment Could somebody enlighten me, does inlining classes make small impact on our ...
3 years, 10 months ago #3
Vitaly Repeshko
LGTM http://codereview.chromium.org/2866008/diff/74078/64017 File src/builtins.cc (right): http://codereview.chromium.org/2866008/diff/74078/64017#newcode152 src/builtins.cc:152: Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top()); "c_entry_fp" is static. http://codereview.chromium.org/2866008/diff/74078/64027 File src/frames.cc (right): ...
3 years, 10 months ago #4
Maxim.Mossienko
3 years, 10 months ago #5
There are some presubmit.py problems.

C:\Projects\v8.current\isolates\src\isolate.h:539:  Do not use variable-length
arrays.  Use an appropriately named ('k' followed by CamelCase) compile-time
constant for the size.  [runtime/arrays] [1]
Done processing isolate.h

top.cc:791:  At least two spaces is best between code and comments 
[whitespace/comments] [2]

top.h:0:  No copyright message found.  You should have a line: "Copyright [year]
<Copyright Owner>"  [legal/copyright] [5]


On 2010/06/21 16:39:43, Vitaly wrote:
> LGTM
> 
> http://codereview.chromium.org/2866008/diff/74078/64017
> File src/builtins.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64017#newcode152
> src/builtins.cc:152:
> Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
> "c_entry_fp" is static.
> 
> http://codereview.chromium.org/2866008/diff/74078/64027
> File src/frames.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64027#newcode211
> src/frames.cc:211: && Isolate::handler(Isolate::Current()->thread_local_top())
> != NULL),
> nit: "&&" should be on the previous line.
> 
> http://codereview.chromium.org/2866008/diff/74078/64031
> File src/handles.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64031#newcode641
> src/handles.cc:641: !Isolate::Current()->MayNamedAccess(*current,
> HEAP->undefined_value(),
> nit: Indent to line up with "c" on the previous line.
> 
> http://codereview.chromium.org/2866008/diff/74078/64041
> File src/ic.cc (right):
> 
> http://codereview.chromium.org/2866008/diff/74078/64041#newcode85
> src/ic.cc:85:
> Isolate::Current()->c_entry_fp(Isolate::Current()->thread_local_top());
> "c_entry_fp" is static.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6