Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2865993002: [Win] Remove unused methods from NativeThemeWin (Closed)

Created:
3 years, 7 months ago by Sungmann Cho
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Remove unused methods from NativeThemeWin The methods below are not used anywhere: * DisableTheming() * GetThemeBorderSize() * GetThemeColorWithDefault() * IsClassicTheme() So we can remove them. BUG=none TEST=compile Review-Url: https://codereview.chromium.org/2865993002 Cr-Commit-Position: refs/heads/master@{#470261} Committed: https://chromium.googlesource.com/chromium/src/+/038181f8e93dfe554791aeedd2facbc3cd01182e

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove the vestiges after the patch set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -100 lines) Patch
M ui/native_theme/native_theme_win.h View 1 3 chunks +0 lines, -38 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 5 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Sungmann Cho
Please take a look. Thanks!
3 years, 7 months ago (2017-05-08 11:26:13 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/2865993002/diff/1/ui/native_theme/native_theme_win.cc File ui/native_theme/native_theme_win.cc (left): https://codereview.chromium.org/2865993002/diff/1/ui/native_theme/native_theme_win.cc#oldcode198 ui/native_theme/native_theme_win.cc:198: return (GetThemeInt(theme, 0, 0, TMT_BORDERSIZE, &border) == S_OK) ...
3 years, 7 months ago (2017-05-08 23:08:54 UTC) #4
Sungmann Cho
Thanks for the review! https://codereview.chromium.org/2865993002/diff/1/ui/native_theme/native_theme_win.cc File ui/native_theme/native_theme_win.cc (left): https://codereview.chromium.org/2865993002/diff/1/ui/native_theme/native_theme_win.cc#oldcode198 ui/native_theme/native_theme_win.cc:198: return (GetThemeInt(theme, 0, 0, TMT_BORDERSIZE, ...
3 years, 7 months ago (2017-05-09 01:39:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865993002/20001
3 years, 7 months ago (2017-05-09 01:41:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/406353) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 02:12:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865993002/20001
3 years, 7 months ago (2017-05-09 03:23:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421506)
3 years, 7 months ago (2017-05-09 05:20:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865993002/20001
3 years, 7 months ago (2017-05-09 06:54:14 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 07:31:06 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/038181f8e93dfe554791aeedd2fa...

Powered by Google App Engine
This is Rietveld 408576698