 Chromium Code Reviews
 Chromium Code Reviews Issue 2865963003:
  [Suggestions UI] Drop Bitmap references from articles under memory pressure.  (Closed)
    
  
    Issue 2865963003:
  [Suggestions UI] Drop Bitmap references from articles under memory pressure.  (Closed) 
  | Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java | 
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java | 
| index 8f406b71b7961f685ec965db08110e26dc5af645..ef1ad2ad4a07fde15aa5ff4cbfe09749bda1c303 100644 | 
| --- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java | 
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java | 
| @@ -6,6 +6,7 @@ package org.chromium.chrome.browser.ntp.snippets; | 
| import android.graphics.Bitmap; | 
| import android.support.annotation.Nullable; | 
| +import org.chromium.base.ReferencePool; | 
| import org.chromium.chrome.browser.suggestions.OfflinableSuggestion; | 
| import java.io.File; | 
| @@ -51,7 +52,7 @@ public class SnippetArticle implements OfflinableSuggestion { | 
| private int mGlobalRank = -1; | 
| /** Bitmap of the thumbnail, fetched lazily, when the RecyclerView wants to show the snippet. */ | 
| - private Bitmap mThumbnailBitmap; | 
| + private ReferencePool.Reference<Bitmap> mThumbnailBitmap; | 
| 
dgn
2017/05/08 17:01:51
nit: import ReferencePool.Reference? I find dotted
 
Bernhard Bauer
2017/05/09 08:51:10
Done. Eclipse auto-import always does it like this
 | 
| /** Stores whether impression of this article has been tracked already. */ | 
| private boolean mImpressionTracked; | 
| @@ -108,11 +109,11 @@ public class SnippetArticle implements OfflinableSuggestion { | 
| * initially unset. | 
| */ | 
| public Bitmap getThumbnailBitmap() { | 
| - return mThumbnailBitmap; | 
| + return mThumbnailBitmap == null ? null : mThumbnailBitmap.get(); | 
| } | 
| /** Sets the thumbnail bitmap for this article. */ | 
| - public void setThumbnailBitmap(Bitmap bitmap) { | 
| + public void setThumbnailBitmap(ReferencePool.Reference<Bitmap> bitmap) { | 
| mThumbnailBitmap = bitmap; | 
| } |