Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 2865963003: [Suggestions UI] Drop Bitmap references from articles under memory pressure. (Closed)
Patch Set: remove annotation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
index 8f406b71b7961f685ec965db08110e26dc5af645..fa1d6d14b81b4c3ddff38147f1792b3de44ccb62 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.ntp.snippets;
import android.graphics.Bitmap;
import android.support.annotation.Nullable;
+import org.chromium.base.DiscardableReferencePool.DiscardableReference;
import org.chromium.chrome.browser.suggestions.OfflinableSuggestion;
import java.io.File;
@@ -51,7 +52,7 @@ public class SnippetArticle implements OfflinableSuggestion {
private int mGlobalRank = -1;
/** Bitmap of the thumbnail, fetched lazily, when the RecyclerView wants to show the snippet. */
- private Bitmap mThumbnailBitmap;
+ private DiscardableReference<Bitmap> mThumbnailBitmap;
/** Stores whether impression of this article has been tracked already. */
private boolean mImpressionTracked;
@@ -108,11 +109,11 @@ public class SnippetArticle implements OfflinableSuggestion {
* initially unset.
*/
public Bitmap getThumbnailBitmap() {
- return mThumbnailBitmap;
+ return mThumbnailBitmap == null ? null : mThumbnailBitmap.get();
}
/** Sets the thumbnail bitmap for this article. */
- public void setThumbnailBitmap(Bitmap bitmap) {
+ public void setThumbnailBitmap(DiscardableReference<Bitmap> bitmap) {
mThumbnailBitmap = bitmap;
}

Powered by Google App Engine
This is Rietveld 408576698