Support for identifying traffic type in data use ascriber

components/data_use_measurement/core/data_use.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_USE_MEASUREMENT_CORE_DATA_USE_H_
 #define COMPONENTS_DATA_USE_MEASUREMENT_CORE_DATA_USE_H_
 
 #include <stdint.h>
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "url/gurl.h"
 
 namespace data_use_measurement {
 
 // Class to store total network data used by some entity.
 class DataUse {
  public:
-  DataUse();
+  enum TrafficType {

[tbansal1, 2017/05/12 15:59:58]

can this be enum class?
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Q5WmkAImanc

[rajendrant, 2017/05/16 00:50:08]

Done.

+    // Unknown.
+    UNKNOWN,

[tbansal1, 2017/05/12 15:59:58]

May be add a TODO to record metrics on the distribution of traffic type. This
would be useful to figure out if there are lot of samples in UNKNOWN or
SERVICE_WORKER buckets (which are both bad).

[rajendrant, 2017/05/16 00:50:08]

Done.

+
+    // User initiated traffic.
+    USER_TRAFFIC,
+
+    // Chrome services.
+    SERVICES,
+
+    // Fetch from ServiceWorker.
+    SERVICE_WORKER,
+  };
+
+  DataUse(TrafficType traffic_type);

[tbansal1, 2017/05/12 15:59:58]

explicit

[rajendrant, 2017/05/16 00:50:08]

Done.

   DataUse(const DataUse& other);
   ~DataUse();
 
   // Merge data use from another instance.
   void MergeFrom(const DataUse& other);
 
   const GURL& url() const { return url_; }
 
   void set_url(const GURL& url) { url_ = url; }
 
   const std::string& description() const { return description_; }
 
   void set_description(const std::string& description) {
     description_ = description;
   }
 
   int64_t total_bytes_received() const { return total_bytes_received_; }
 
   int64_t total_bytes_sent() const { return total_bytes_sent_; }
 
+  TrafficType traffic_type() { return traffic_type_; }

[tbansal1, 2017/05/12 15:59:58]

const function

[rajendrant, 2017/05/16 00:50:08]

Done.

+
  private:
   friend class DataUseRecorder;

[tbansal1, 2017/05/12 15:59:58]

TODO to remove this friend.
This probably means that DataUseRecorder is writing to the private members of
this class. This makes it difficult to understand how this class interacts with
other classes.

[rajendrant, 2017/05/16 00:50:08]

Done.

 
   GURL url_;
   std::string description_;
+  const TrafficType traffic_type_;
 
   int64_t total_bytes_sent_;
   int64_t total_bytes_received_;

[tbansal1, 2017/05/12 15:59:58]

May be add a TODO to add thread checker.

[tbansal1, 2017/05/12 15:59:58]

DISALLOW_COPY_AND_ASSIGN
or override the assignment operator.

[rajendrant, 2017/05/16 00:50:08]

Done.

[rajendrant, 2017/05/16 00:50:08]

Thread checker could be too much for this class. This is supposed to be light
object sent across data use observers.

In future this class could derive from base::SupportsUserData so that observers
can annotate arbitrary information to this. For example, Freighter could
annotate this with amortized bytes.

WDYT

 };
 
 }  // namespace data_use_measurement
 
 #endif  // COMPONENTS_DATA_USE_MEASUREMENT_CORE_DATA_USE_H_