Use FileSystem to read files in SourceLoader and TranslateUri.

Use FileSystem to read files in SourceLoader and TranslateUri.

This is a prerequisite for writing fast unit tests, as I would like
to do while working on the incremental kernel driver.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cc91d045149fe9eab81a1819b1aaf73fcc5b96f0

[Paul Berry, 2017-05-06 13:24:43]

lgtm

[scheglov, 2017-05-06 20:09:35]

Description was changed from

==========
Use FileSystem to read files in SourceLoader and TranslateUri.

This is a prerequisite for writing fast unit tests, as I would like
to do while working on the incremental kernel driver.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Use FileSystem to read files in SourceLoader and TranslateUri.

This is a prerequisite for writing fast unit tests, as I would like
to do while working on the incremental kernel driver.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cc91d045149fe9eab81a1819b1aaf73fcc5b96f0
==========

[scheglov, 2017-05-06 20:09:37]

Committed patchset #1 (id:1) manually as
cc91d045149fe9eab81a1819b1aaf73fcc5b96f0 (presubmit successful).

[ahe, 2017-05-08 10:06:14]

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:91:
zeroTerminatedBytes.setRange(0, rawBytes.length, rawBytes);
I'd appreciate if we can roll this back until the API supports reading into a a
byte list.

Copying bytes is expensive.

[Siggi Cherem (dart-lang), 2017-05-08 16:38:22]

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:91:
zeroTerminatedBytes.setRange(0, rawBytes.length, rawBytes);
On 2017/05/08 10:06:14, ahe wrote:
> I'd appreciate if we can roll this back until the API supports reading into a
a
> byte list.

Another option: instead of adding an API to read into a list, we could extend
the readAsBytes API to match scanner/io.dart#readBytesFromFile  (take an
optional `ensureZeroTermination` boolean)


> 
> Copying bytes is expensive.

[scheglov, 2017-05-08 16:53:36]

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2865843002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:91:
zeroTerminatedBytes.setRange(0, rawBytes.length, rawBytes);
On 2017/05/08 16:38:22, Siggi Cherem (dart-lang) wrote:
> On 2017/05/08 10:06:14, ahe wrote:
> > I'd appreciate if we can roll this back until the API supports reading into
a
> a
> > byte list.
> 
> Another option: instead of adding an API to read into a list, we could extend
> the readAsBytes API to match scanner/io.dart#readBytesFromFile  (take an
> optional `ensureZeroTermination` boolean)
> 
> 
> > 
> > Copying bytes is expensive.
> 

Well, we could do this.
OTOH API bloating is not nice.