Issue 286583004: Skip presubmit errors caused by lint update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286583004: Skip presubmit errors caused by lint update. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 6 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.26

Visibility:
Public.

More Reviews

Description

Skip presubmit errors caused by lint update. Prevent presubmit errors when merging to the 3.26 branch. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21289

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	tools/presubmit.py	View		3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. We could also backmerge the fix from bleeding_edge... but this is safer.

6 years, 7 months ago (2014-05-13 13:48:41 UTC) #2

Michael Achenbach

Committed patchset #1 manually as r21289 (presubmit successful).

6 years, 7 months ago (2014-05-13 14:14:48 UTC) #3

ulan

6 years, 6 months ago (2014-06-05 06:29:24 UTC) #4

Message was sent while issue was closed.

On 2014/05/13 14:14:48, Michael Achenbach wrote:
> Committed patchset #1 manually as r21289 (presubmit successful).

This change did not bump src/version.cc

Expand Messages | Collapse Messages