Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 286583002: Pull DomDistillerOptions up to the DistillerFactory (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Pull DomDistillerOptions up to the DistillerFactory This allows the creator of the DistillerFactory to set the DomDistillerOptions for all pages distilled by Distillers from that factory. Add an option to the content_extractor to extract just the text from the page. DEPENDSON= https://codereview.chromium.org/270663005/ https://codereview.chromium.org/286453002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272431

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix bad rebase #

Patch Set 5 : :/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -34 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/dom_distiller.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/distiller.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M components/dom_distiller/core/distiller.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M components/dom_distiller/core/distiller_page.h View 2 chunks +6 lines, -3 lines 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 1 2 3 22 chunks +51 lines, -18 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 3 chunks +9 lines, -1 line 0 comments Download
M third_party/dom_distiller_js/dom_distiller_js.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
cjhopman
nyquist: *
6 years, 7 months ago (2014-05-13 16:49:24 UTC) #1
nyquist
lgtm
6 years, 7 months ago (2014-05-13 17:32:59 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-20 21:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/286583002/60001
6 years, 7 months ago (2014-05-20 21:29:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 03:19:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 03:24:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/29312)
6 years, 7 months ago (2014-05-21 03:24:25 UTC) #7
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-22 18:49:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/286583002/70001
6 years, 7 months ago (2014-05-22 18:50:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 21:39:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 21:55:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/154669)
6 years, 7 months ago (2014-05-22 21:55:48 UTC) #12
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-23 01:31:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/286583002/90001
6 years, 7 months ago (2014-05-23 01:31:33 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:27:33 UTC) #15
Message was sent while issue was closed.
Change committed as 272431

Powered by Google App Engine
This is Rietveld 408576698