Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6108)

Unified Diff: chrome/browser/resources/chromeos/keyboard_overlay.js

Issue 2865793002: Remove the BackspaceGoesBack flag. (Closed)
Patch Set: Add TODO Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/keyboard_overlay.js
diff --git a/chrome/browser/resources/chromeos/keyboard_overlay.js b/chrome/browser/resources/chromeos/keyboard_overlay.js
index 86a3ab02549f204147a3c19a8ae80845840565e8..8fec1419f6a14b9d5a34b879122393b2b87e53b4 100644
--- a/chrome/browser/resources/chromeos/keyboard_overlay.js
+++ b/chrome/browser/resources/chromeos/keyboard_overlay.js
@@ -227,13 +227,11 @@ function getShortcutData() {
delete shortcutDataCache['0<>CTRL<>SHIFT'];
}
- if (!loadTimeData.getBoolean('backspaceGoesBackFeatureEnabled')) {
- // If the "backspace key goes back" experiment is not enabled, then we
- // clear the shortcuts for Backspace and Shift+Backspace to go back or
- // forward respectively.
- delete shortcutDataCache['backspace'];
- delete shortcutDataCache['backspace<>SHIFT'];
- }
+ // TODO(ojan): crbug.com/721141 Delete these two lines after running
+ // src/tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py
+ // to not have these added to the shortcutDataCache in the first place.
+ delete shortcutDataCache['backspace'];
+ delete shortcutDataCache['backspace<>SHIFT'];
afakhry 2017/05/11 01:19:35 Please remove these lines as well as the correspon
ojan 2017/05/11 18:25:25 done
return shortcutDataCache;
}

Powered by Google App Engine
This is Rietveld 408576698