Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2865793002: Remove the BackspaceGoesBack flag. (Closed)
Patch Set: merge to trunk Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 7db71e164a7a8453c8c95c403dcb8facded339de..7486eea2294ce6148ecb1ec55bd8b6ec0cc960bd 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -11,7 +11,6 @@
#include "base/command_line.h"
#include "base/debug/debugging_flags.h"
#include "base/debug/profiler.h"
-#include "base/feature_list.h"
#include "base/macros.h"
#include "base/metrics/user_metrics.h"
#include "build/build_config.h"
@@ -37,7 +36,6 @@
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/webui/inspect_ui.h"
-#include "chrome/common/chrome_features.h"
#include "chrome/common/content_restriction.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/profiling.h"
@@ -308,20 +306,14 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
switch (id) {
// Navigation commands
case IDC_BACKSPACE_BACK:
- if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
- GoBack(browser_, disposition);
- else
- window()->MaybeShowNewBackShortcutBubble(false);
+ window()->MaybeShowNewBackShortcutBubble(false);
break;
case IDC_BACK:
window()->HideNewBackShortcutBubble();
GoBack(browser_, disposition);
break;
case IDC_BACKSPACE_FORWARD:
- if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
- GoForward(browser_, disposition);
- else
- window()->MaybeShowNewBackShortcutBubble(true);
+ window()->MaybeShowNewBackShortcutBubble(true);
break;
case IDC_FORWARD:
window()->HideNewBackShortcutBubble();

Powered by Google App Engine
This is Rietveld 408576698