Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3109)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 2865793002: Remove the BackspaceGoesBack flag. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index e917e1714c823428dc008522b8c9da25e9a191f0..4ea15d23bb68ae8b27e16db7301a03b916689b1b 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -308,20 +308,14 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
switch (id) {
// Navigation commands
case IDC_BACKSPACE_BACK:
- if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
- GoBack(browser_, disposition);
- else
- window()->MaybeShowNewBackShortcutBubble(false);
+ window()->MaybeShowNewBackShortcutBubble(false);
break;
case IDC_BACK:
window()->HideNewBackShortcutBubble();
GoBack(browser_, disposition);
break;
case IDC_BACKSPACE_FORWARD:
- if (base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature))
- GoForward(browser_, disposition);
- else
- window()->MaybeShowNewBackShortcutBubble(true);
+ window()->MaybeShowNewBackShortcutBubble(true);
break;
case IDC_FORWARD:
window()->HideNewBackShortcutBubble();

Powered by Google App Engine
This is Rietveld 408576698