Remove the BackspaceGoesBack flag.

chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h"
 
 #include <stddef.h>
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
-#include "base/feature_list.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/chromeos_switches.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
@@ skipping 143 matching lines @@
     {"keyboardOverlayFocusAddressBar", IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR},
     {"keyboardOverlayFocusAddressBarInSearchMode",
      IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR_IN_SEARCH_MODE},
     {"keyboardOverlayFocusBookmarks", IDS_KEYBOARD_OVERLAY_FOCUS_BOOKMARKS},
     {"keyboardOverlayFocusShelf", IDS_KEYBOARD_OVERLAY_FOCUS_SHELF},
     {"keyboardOverlayFocusNextPane", IDS_KEYBOARD_OVERLAY_FOCUS_NEXT_PANE},
     {"keyboardOverlayFocusPreviousPane",
      IDS_KEYBOARD_OVERLAY_FOCUS_PREVIOUS_PANE},
     {"keyboardOverlayFocusToolbar", IDS_KEYBOARD_OVERLAY_FOCUS_TOOLBAR},
     {"keyboardOverlayGoBack", IDS_KEYBOARD_OVERLAY_GO_BACK},
     {"keyboardOverlayGoForward", IDS_KEYBOARD_OVERLAY_GO_FORWARD},

[afakhry, 2017/05/11 01:19:35]

Please remove the above two entries if you don't need them anymore.
Also remove the corresponding IDS_* from the chromeos_strings.grdp

[ojan, 2017/05/11 18:25:25]

Done

[michaelpg, 2017/05/11 19:10:14]

Oops, my drafts didn't get published. Ojan: these are still used, grep
keyboard_overlay_data.js for 'keyboardOverlayGoBack' and
'keyboardOverlayGoForward'.

[michaelpg, 2017/05/11 19:10:14]

(These strings are still used by the alt keys, so they should stay.)

     {"keyboardOverlayHelp", IDS_KEYBOARD_OVERLAY_HELP},
     {"keyboardOverlayHistory", IDS_KEYBOARD_OVERLAY_HISTORY},
     {"keyboardOverlayHome", IDS_KEYBOARD_OVERLAY_HOME},
     {"keyboardOverlayIncreaseKeyBrightness",
      IDS_KEYBOARD_OVERLAY_INCREASE_KEY_BRIGHTNESS},
     {"keyboardOverlayInputUnicodeCharacters",
      IDS_KEYBOARD_OVERLAY_INPUT_UNICODE_CHARACTERS},
     {"keyboardOverlayInsert", IDS_KEYBOARD_OVERLAY_INSERT},
     {"keyboardOverlayJavascriptConsole",
      IDS_KEYBOARD_OVERLAY_JAVASCRIPT_CONSOLE},
@@ skipping 114 matching lines @@
                     base::UTF8ToUTF16(kLearnMoreURL));
   source->AddBoolean("keyboardOverlayHasChromeOSDiamondKey",
                      base::CommandLine::ForCurrentProcess()->HasSwitch(
                          chromeos::switches::kHasChromeOSDiamondKey));
   source->AddBoolean("keyboardOverlayTopRowKeysAreFunctionKeys",
                      TopRowKeysAreFunctionKeys(profile));
   ash::Shell* shell = ash::Shell::Get();
   display::DisplayManager* display_manager = shell->display_manager();
   source->AddBoolean("keyboardOverlayIsDisplayUIScalingEnabled",
                      display_manager->IsDisplayUIScalingEnabled());
-  source->AddBoolean(
-      "backspaceGoesBackFeatureEnabled",
-      base::FeatureList::IsEnabled(features::kBackspaceGoesBackFeature));
   source->SetJsonPath("strings.js");
   source->AddResourcePath("keyboard_overlay.js", IDR_KEYBOARD_OVERLAY_JS);
   source->SetDefaultResource(IDR_KEYBOARD_OVERLAY_HTML);
   return source;
 }
 
 }  // namespace
 
 // The handler for Javascript messages related to the "keyboardoverlay" view.
 class KeyboardOverlayHandler
@@ skipping 95 matching lines @@
 
 KeyboardOverlayUI::KeyboardOverlayUI(content::WebUI* web_ui)
     : WebDialogUI(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   web_ui->AddMessageHandler(base::MakeUnique<KeyboardOverlayHandler>(profile));
 
   // Set up the chrome://keyboardoverlay/ source.
   content::WebUIDataSource::Add(profile,
                                 CreateKeyboardOverlayUIHTMLSource(profile));
 }