Remove the BackspaceGoesBack flag.

chrome/browser/resources/chromeos/keyboard_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // <include src="keyboard_overlay_data.js">
 
 var BASE_KEYBOARD = {
   top: 0,
   left: 0,
   width: 1237,
@@ skipping 209 matching lines @@
 
   if (!isDisplayUIScalingEnabled()) {
     // Zoom screen in
     delete shortcutDataCache['+<>CTRL<>SHIFT'];
     // Zoom screen out
     delete shortcutDataCache['-<>CTRL<>SHIFT'];
     // Reset screen zoom
     delete shortcutDataCache['0<>CTRL<>SHIFT'];
   }
 
-  if (!loadTimeData.getBoolean('backspaceGoesBackFeatureEnabled')) {
-    // If the "backspace key goes back" experiment is not enabled, then we
-    // clear the shortcuts for Backspace and Shift+Backspace to go back or
-    // forward respectively.
-    delete shortcutDataCache['backspace'];
-    delete shortcutDataCache['backspace<>SHIFT'];
-  }
+  delete shortcutDataCache['backspace'];
+  delete shortcutDataCache['backspace<>SHIFT'];

[Peter Kasting, 2017/05/06 04:56:13]

Do we need these lines anymore?

[ojan, 2017/05/10 18:07:06]

I don't know. I was just maintaining behavior with the flag off.

[michaelpg, 2017/05/10 23:41:51]

shortcutDataCache starts with these keys populated, so yes, the CL as-is needs
these lines. (If you remove these lines and build, you'll see that the overlay
shows the removed shortcuts again. You can also set a breakpoint here at
chrome://keyboardoverlay to see the existing values at these keys.)

We should remove them, though, by removing the same keys from the data it's
drawing from. shortcutDataCache comes from:

https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/keyboa...

which says it's a generated file -- I'd look there to see how to remove these
entries.

(BTW, because the equivalent alt+arrow shortcuts have the same strings, you
don't need to worry about removing them.)

 
   return shortcutDataCache;
 }
 
 /**
  * Returns the keyboard overlay ID.
  * @return {string} Keyboard overlay ID.
  */
 function getKeyboardOverlayId() {
   return keyboardOverlayId;
@@ skipping 705 matching lines @@
 function onWidgetShown() {
   setTimeout(function() {
     // Show and focus the instructions div after a delay so that chrome vox
     // speaks it correctly.
     $('instructions').style.visibility = 'visible';
     $('instructions').focus();
   }, 500);
 }
 
 document.addEventListener('DOMContentLoaded', init);