Fix all remaining print preview closure compiler errors

chrome/browser/resources/print_preview/settings/more_settings.js

Index: chrome/browser/resources/print_preview/settings/more_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/more_settings.js b/chrome/browser/resources/print_preview/settings/more_settings.js
index 260cc1b3011fe0a172b8cb58169ac6437c2d80a4..6c07f9e8c78a1e1c24d5990b708bae984c8562de 100644
--- a/chrome/browser/resources/print_preview/settings/more_settings.js
+++ b/chrome/browser/resources/print_preview/settings/more_settings.js
@@ -2,9 +2,22 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+cr.exportPath('print_preview');
+
+/**
+ * Which settings are visible to the user.
+ * @enum {number}
+ */
+print_preview.MoreSettingsSettingsToShow = {
+  MOST_POPULAR: 1,
+  ALL: 2
+};
+
 cr.define('print_preview', function() {
   'use strict';
 
+  var SettingsToShow = print_preview.MoreSettingsSettingsToShow;
+
   /**
    * Toggles visibility of the specified printing options sections.
    * @param {!print_preview.DestinationStore} destinationStore To listen for
@@ -23,8 +36,8 @@ cr.define('print_preview', function() {
     /** @private {!Array<print_preview.SettingsSection>} */
     this.settingsSections_ = settingsSections;
 
-    /** @private {MoreSettings.SettingsToShow} */
-    this.settingsToShow_ = MoreSettings.SettingsToShow.MOST_POPULAR;
+    /** @private {print_preview.MoreSettingsSettingsToShow} */
+    this.settingsToShow_ = SettingsToShow.MOST_POPULAR;
 
     /** @private {boolean} */
     this.capabilitiesReady_ = false;
@@ -39,21 +52,13 @@ cr.define('print_preview', function() {
     this.metrics_ = new print_preview.PrintSettingsUiMetricsContext();
   }
 
-  /**
-   * Which settings are visible to the user.
-   * @enum {number}
-   */
-  MoreSettings.SettingsToShow = {
-    MOST_POPULAR: 1,
-    ALL: 2
-  };
-
   MoreSettings.prototype = {
     __proto__: print_preview.Component.prototype,
 
     /** @return {boolean} Returns {@code true} if settings are expanded. */
     get isExpanded() {
-      return this.settingsToShow_ == MoreSettings.SettingsToShow.ALL;
+      return this.settingsToShow_ == SettingsToShow.
+                                     ALL;

[dpapad, 2017/05/08 23:50:30]

Can this fit in previous line?

[rbpotter, 2017/05/09 00:08:52]

Done.

     },
 
     /** @override */
@@ -87,9 +92,9 @@ cr.define('print_preview', function() {
      */
     onClick_: function() {
       this.settingsToShow_ =
-          this.settingsToShow_ == MoreSettings.SettingsToShow.MOST_POPULAR ?
-              MoreSettings.SettingsToShow.ALL :
-              MoreSettings.SettingsToShow.MOST_POPULAR;
+          this.settingsToShow_ == SettingsToShow.MOST_POPULAR ?
+              SettingsToShow.ALL :
+              SettingsToShow.MOST_POPULAR;
       this.updateState_(false);
       this.metrics_.record(this.isExpanded ?
           print_preview.Metrics.PrintSettingsUiBucket.MORE_SETTINGS_CLICKED :
@@ -131,7 +136,7 @@ cr.define('print_preview', function() {
       if (!this.capabilitiesReady_)
         return;
 
-      var all = this.settingsToShow_ == MoreSettings.SettingsToShow.ALL;
+      var all = this.settingsToShow_ == SettingsToShow.ALL;
       this.getChildElement('.more-settings-label').textContent =
           loadTimeData.getString(all ? 'lessOptionsLabel' : 'moreOptionsLabel');
       var iconEl = this.getChildElement('.more-settings-icon');
@@ -157,7 +162,7 @@ cr.define('print_preview', function() {
         fadeOutElement(this.getElement());
 
       var collapseContent =
-          this.settingsToShow_ == MoreSettings.SettingsToShow.MOST_POPULAR &&
+          this.settingsToShow_ == SettingsToShow.MOST_POPULAR &&
           hasSectionsToToggle;
       this.settingsSections_.forEach(function(section) {
         section.setCollapseContent(collapseContent, noAnimation);