Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

Issue 2865633004: Fix all remaining print preview closure compiler errors (Closed)
Patch Set: Fix onkeydown function Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/previewarea/margin_control_container.js
diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
index 31085f6d80aaafaf8640ec71090ae289ebc68a0e..33ab6b2f34a5828c43d62723896295da867a9699 100644
--- a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
+++ b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js
@@ -108,7 +108,7 @@ cr.define('print_preview', function() {
* @private
*/
this.clippingSize_ = null;
- };
+ }
/**
* CSS classes used by the custom margins component.
@@ -272,7 +272,7 @@ cr.define('print_preview', function() {
/**
* @param {string} value Value to parse to points. E.g. '3.40"' or '200mm'.
- * @return {number} Value in points represented by the input value.
+ * @return {?number} Value in points represented by the input value.
* @private
*/
parseValueToPts_: function(value) {
@@ -369,9 +369,10 @@ cr.define('print_preview', function() {
/**
* Called when the mouse moves onto the component. Shows the margin
* controls.
+ * @param {!Event} event Contains element mouse moved from.
* @private
*/
- onMouseOver_: function() {
+ onMouseOver_: function(event) {
var fromElement = event.fromElement;
while (fromElement != null) {
if (fromElement == this.getElement()) {
@@ -389,6 +390,7 @@ cr.define('print_preview', function() {
/**
* Called when the mouse moves off of the component. Hides the margin
* controls.
+ * @param {!Event} event Contains element mouse moved to.
* @private
*/
onMouseOut_: function(event) {

Powered by Google App Engine
This is Rietveld 408576698