Fix all remaining print preview closure compiler errors

chrome/browser/resources/print_preview/search/destination_list_item.js

Index: chrome/browser/resources/print_preview/search/destination_list_item.js
diff --git a/chrome/browser/resources/print_preview/search/destination_list_item.js b/chrome/browser/resources/print_preview/search/destination_list_item.js
index 58ded04a498b856881afd9fdd189b3a7594ebab7..9a9fe58de41b4791bda1f2e5e281a83809c69074 100644
--- a/chrome/browser/resources/print_preview/search/destination_list_item.js
+++ b/chrome/browser/resources/print_preview/search/destination_list_item.js
@@ -38,7 +38,7 @@ cr.define('print_preview', function() {
      * @private
      */
     this.query_ = query;
-  };
+  }
 
   /**
    * Event types dispatched by the destination list item.
@@ -75,7 +75,7 @@ cr.define('print_preview', function() {
           this.onRegisterPromoClicked_.bind(this));
     },
 
-    /** @return {!print_preiew.Destination} */
+    /** @return {!print_preview.Destination} */
     get destination() {
       return this.destination_;
     },
@@ -241,7 +241,7 @@ cr.define('print_preview', function() {
     /**
      * Shows/Hides the configuring in progress message and starts/stops its
      * animation accordingly.
-     * @param {bool} show If the message and animation should be shown.
+     * @param {boolean} show If the message and animation should be shown.
      * @private
      */
     updateConfiguringMessage_: function(show) {
@@ -287,7 +287,7 @@ cr.define('print_preview', function() {
     /**
      * Called when the key is pressed on the destination item. Dispatches a
      * SELECT event when Enter is pressed.
-     * @param {KeyboardEvent} e Keyboard event to process.
+     * @param {!KeyboardEvent} e Keyboard event to process.
      * @private
      */
     onKeyDown_: function(e) {
@@ -319,7 +319,7 @@ cr.define('print_preview', function() {
      * Handles click and 'Enter' key down events for the extension icon element.
      * It opens extensions page with the extension associated with the
      * destination highlighted.
-     * @param {MouseEvent|KeyboardEvent} e The event to handle.
+     * @param {Event} e The event to handle.
      * @private
      */
     onExtensionIconClicked_: function(e) {
@@ -330,15 +330,15 @@ cr.define('print_preview', function() {
     /**
      * Handles key down event for the extensin icon element. Keys different than
      * 'Enter' are ignored.
-     * @param {KeyboardEvent} e The event to handle.
+     * @param {Event} e The event to handle.
      * @private
      */
     onExtensionIconKeyDown_: function(e) {
-      if (hasKeyModifiers(e))
+      if (e && hasKeyModifiers(e))

[Dan Beam, 2017/05/10 00:00:14]

same nit regarding !Event vs e && (just to type filter out null)

[rbpotter, 2017/05/10 01:56:23]

Does not work here as this gets assigned to extensionIconEl.keydown,
which requires (function ((Event|null)): ?|null).

Changed to an assert instead, let me know if it should be something
different.

[dpapad, 2017/05/10 02:54:12]

Nit(optional): It seems that onkeydown,onclick are erroneously annotated with
Event instead of !Event, see [1]. Perhaps changing the code to use
addEventListener('click', ...) instead would allow you to use @param{!Event}
here and remove the assertion.

[1]
https://github.com/google/closure-compiler/blob/02ee72c0f8248ffe6be9f9efd591f...
[2]
https://github.com/google/closure-compiler/blob/8ac08c03cd695b84f8a79ac3a1338...

[dpapad, 2017/05/10 02:59:20]

Actually you should probably not follow my previous suggestion, because calling
addEventListener() and using onclick, onkeydown are not equivalent here.

addEventListener() adds a new listener every time it is called, whereas onclick
= ..., replaces the existing listener. The enclosing code [1] seems to be
executed multiple times, so you don't want to add multiple listeners every time
is called.

[1]
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/s...

[Dan Beam, 2017/05/10 03:18:35]

this works for me 
http://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClos...

[rbpotter, 2017/05/10 03:42:10]

Done. Should I change it to !KeyboardEvent if we are going to cast the
function anyway? (was KeyboardEvent before this CL)

         return;
       if (e.keyCode != 13 /* Enter */)
         return;
-      this.onExtensionIconClicked_(event);
+      this.onExtensionIconClicked_(e);
     }
   };