chrome/browser/resources/print_preview/previewarea/margin_control_container.js - Issue 2865633004: Fix all remaining print preview closure compiler errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

Issue 2865633004: Fix all remaining print preview closure compiler errors (Closed)

Patch Set: Remove TODO and uncomment line Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/previewarea/margin_control.js ('k') | chrome/browser/resources/print_preview/previewarea/preview_area.js » ('j') | chrome/browser/resources/print_preview/previewarea/preview_area.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/previewarea/margin_control_container.js

diff --git a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

index 31085f6d80aaafaf8640ec71090ae289ebc68a0e..e16483f4c1f6787183fb1c24a42b9b00e89706ae 100644

--- a/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

+++ b/chrome/browser/resources/print_preview/previewarea/margin_control_container.js

@@ -108,7 +108,7 @@ cr.define('print_preview', function() {

* @private

this.clippingSize_ = null;

- };

+ }

/**

* CSS classes used by the custom margins component.

@@ -272,7 +272,7 @@ cr.define('print_preview', function() {

/**

* @param {string} value Value to parse to points. E.g. '3.40"' or '200mm'.

- * @return {number} Value in points represented by the input value.

+ * @return {?number} Value in points represented by the input value.

* @private

parseValueToPts_: function(value) {

@@ -371,7 +371,7 @@ cr.define('print_preview', function() {

* controls.

Dan Beam 2017/05/09 21:25:47 nit: @param

rbpotter 2017/05/09 22:32:14 Done.

* @private

- onMouseOver_: function() {

+ onMouseOver_: function(event) {

var fromElement = event.fromElement;

while (fromElement != null) {

if (fromElement == this.getElement()) {