Fix all remaining print preview closure compiler errors

chrome/test/data/webui/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 GEN('#include "base/feature_list.h"');
 GEN('#include "chrome/common/chrome_features.h"');
 
 /**
  * Test fixture for print preview WebUI testing.
  * @constructor
  * @extends {testing.Test}
  */
 function PrintPreviewWebUITest() {
   testing.Test.call(this);
   this.nativeLayer_ = null;
   this.initialSettings_ = null;
   this.localDestinationInfos_ = null;
   this.previewArea_ = null;
 }
 
 /**
+ * Instance of PrintPreview for the test.
+ */
+var printPreview;
+
+/**
  * Index of the "Save as PDF" printer.
  * @type {number}
  * @const
  */
 PrintPreviewWebUITest.PDF_INDEX = 0;
 
 /**
  * Index of the Foo printer.
  * @type {number}
  * @const
@@ skipping 42 matching lines @@
   },
 
   /**
    * Stub out low-level functionality like the NativeLayer and
    * CloudPrintInterface.
    * @this {PrintPreviewWebUITest}
    * @override
    */
   preLoad: function() {
     window.addEventListener('DOMContentLoaded', function() {
+      print_preview.IsWebUITest = true;

[dpapad, 2017/05/08 23:39:48]

We are adding a DOMContentLoaded handler here, and also one in print_preview
prod code, and we rely on the order that the two listeners execute (first one
sets a boolean, second one reads the boolean).

I think this is a bit fragile. Probably better to undo this change for now and
just leave the global "var printPriview" variable in the prod code and add a
comment that the reference is used by tests.

[rbpotter, 2017/05/09 00:08:52]

Done.

       function NativeLayerStub() {
         cr.EventTarget.call(this);
         this.printStarted_ = false;
       }
       NativeLayerStub.prototype = {
         __proto__: cr.EventTarget.prototype,
         isPrintStarted: function() { return this.printStarted_; },
         previewReadyForTest: function() {},
         startGetInitialSettings: function() {},
         startGetLocalDestinations: function() {},
@@ skipping 18 matching lines @@
         search: function(isRecent) {}
       };
       var oldCpInterfaceEventType = cloudprint.CloudPrintInterfaceEventType;
       cloudprint.CloudPrintInterface = CloudPrintInterfaceStub;
       cloudprint.CloudPrintInterfaceEventType = oldCpInterfaceEventType;
 
       print_preview.PreviewArea.prototype.checkPluginCompatibility_ =
           function() {
         return false;
       };
+      printPreview = new print_preview.PrintPreview();
+      printPreview.initialize();
+
     }.bind(this));
   },
 
   /**
    * Dispatch the INITIAL_SETTINGS_SET event. This call is NOT async and will
    * happen in the same thread.
    */
   setInitialSettings: function() {
     var initialSettingsSetEvent =
         new Event(print_preview.NativeLayer.EventType.INITIAL_SETTINGS_SET);
@@ skipping 487 matching lines @@
   var scalingSettings = $('scaling-settings');
 
   // Check that options are collapsed (section is visible, because duplex is
   // available).
   checkSectionVisible(otherOptions, true);
   checkElementDisplayed(fitToPage, false);
   if (isPrintAsImageEnabled())
     checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, false);
   checkSectionVisible(scalingSettings, false);
-
   this.expandMoreSettings();
 
   checkElementDisplayed(fitToPage, false);
   if (isPrintAsImageEnabled())
     checkElementDisplayed(rasterize, false);
   checkSectionVisible(mediaSize, true);
   checkSectionVisible(scalingSettings, true);
-
   this.waitForAnimationToEnd('more-settings');
 });
 
 // When the source is "PDF", depending on the selected destination printer, we
 // show/hide the fit to page option and hide media size selection.
 TEST_F('PrintPreviewWebUITest', 'SourceIsPDFCapabilities', function() {
   this.initialSettings_.isDocumentModifiable_ = false;
   this.setInitialSettings();
   this.setLocalDestinations();
   this.setCapabilities(getCddTemplate("FooDevice"));
@@ skipping 794 matching lines @@
   this.dispatchPreviewDone();
 
   // Has active print button and successfully "prints", indicating recovery
   // from error state.
   expectFalse(printButton.disabled);
   expectFalse(this.hasPrinted());
   printButton.click();
   expectTrue(this.hasPrinted());
   testDone();
 });