Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 286563002: Fix an issue that jni generator is ignoring input param (Closed)

Created:
6 years, 7 months ago by qinmin
Modified:
6 years, 7 months ago
Reviewers:
apiccion, trchen
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Visibility:
Public.

Description

Fix an issue that jni generator is ignoring input param If there is an extra white space in the param, the param will not be used in the auto generated jni file BUG=372459 R=trchen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
trchen
lgtm. lol
6 years, 7 months ago (2014-05-13 00:06:23 UTC) #1
qinmin
6 years, 7 months ago (2014-05-13 00:16:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r269932 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698