Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: content/browser/appcache/appcache_url_loader_job.h

Issue 2865613002: Add an abstraction for a job in the AppCacheRequestHandler class. (Closed)
Patch Set: Fix build failures Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_JOB_H_
6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_JOB_H_
7
8 #include "base/logging.h"
9 #include "base/strings/string16.h"
10 #include "content/browser/appcache/appcache_job.h"
11 #include "content/common/content_export.h"
12
13 namespace content {
14
15 class AppCacheHost;
16 class AppCacheRequest;
17 class AppCacheStorage;
18
19 // AppCacheJob wrapper for the AppCacheURLLoaderJob class.
jam 2017/05/05 23:15:25 nit: the comment is a bit confusing. maybe it shou
ananta 2017/05/06 03:01:35 Done.
20 class CONTENT_EXPORT AppCacheURLLoaderJob : public AppCacheJob {
21 public:
22 ~AppCacheURLLoaderJob() override;
23
24 // AppCacheJob overrides.
25 void Kill() override;
26 bool IsStarted() const override;
27 bool IsWaiting() const override;
28 bool IsDeliveringAppCacheResponse() const override;
29 bool IsDeliveringNetworkResponse() const override;
30 bool IsDeliveringErrorResponse() const override;
31 bool IsCacheEntryNotFound() const override;
32 void DeliverAppCachedResponse(const GURL& manifest_url,
33 int64_t cache_id,
34 const AppCacheEntry& entry,
35 bool is_fallback) override;
36 void DeliverNetworkResponse() override;
37 void DeliverErrorResponse() override;
38 const GURL& GetURL() const override;
39
40 protected:
41 // AppCacheJob::Create() creates this instance.
jam 2017/05/05 23:15:25 ditto
ananta 2017/05/06 03:01:35 Leaving this as is based on the response in the ot
42 friend class AppCacheJob;
43
44 AppCacheURLLoaderJob();
45
46 GURL url_;
47
48 DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoaderJob);
49 };
50
51 } // namespace content
52
53 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698