|
|
Revert "Void is not required to be `null` anymore."
This reverts commit 6caf9ef4439e20ea726d8a5383ed34d42b02c84b.
Commit breaks vm-kernel-linux-debug-x64-be.
Triggers asserts like
../../runtime/vm/flow_graph_compiler_x64.cc: 658: error: expected: dst_type.IsMalformedOrMalbounded() || (!dst_type.IsDynamicType() && !dst_type.IsObjectType() && !dst_type.IsVoidType())
Quick-check with python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options --no-enable-malloc-hooks isolate
BUG=
Committed: https://github.com/dart-lang/sdk/commit/30d9bf2ed3225f04c52d999a1a5c61e63a90578d
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+108 lines, -100 lines) |
Patch |
 |
M |
CHANGELOG.md
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/inferrer/type_system.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart
|
View
|
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/js_backend/impact_transformer.dart
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/ssa/codegen.dart
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/ssa/nodes.dart
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_builder.cc
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_arm.cc
|
View
|
|
3 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_arm64.cc
|
View
|
|
3 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_ia32.cc
|
View
|
|
3 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_mips.cc
|
View
|
|
3 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_compiler_x64.cc
|
View
|
|
4 chunks |
+9 lines, -5 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_type_propagator.cc
|
View
|
|
7 chunks |
+28 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/object.cc
|
View
|
|
4 chunks |
+5 lines, -12 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/js_runtime/lib/js_helper.dart
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/co19/co19-co19.status
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
tests/language/return_type_test.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
tests/language/void_check_test.dart
|
View
|
|
1 chunk |
+0 lines, -37 lines |
0 comments
|
Download
|
|
M |
tests/language/void_type_test.dart
|
View
|
|
3 chunks |
+19 lines, -9 lines |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|
Chromium Code Reviews
Issue
2865603003:
Revert "Void is not required to be `null` anymore." (Closed)
