Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js

Issue 2865573003: DevTools: support live coverage (Closed)
Patch Set: minor polish on corner cases Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
index 41688edbbefad50b5304eae34b1f06c755c811dc..13c1d7b3b4628e673d1a1f6205e6d0315144393f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
@@ -295,27 +295,22 @@ SDK.CSSModel = class extends SDK.SDKModel {
.catchException(false);
}
- startRuleUsageTracking() {
+ startCoverage() {
this._agent.startRuleUsageTracking();
}
/**
* @return {!Promise<!Array<!Protocol.CSS.RuleUsage>>}
*/
- ruleListPromise() {
- /**
- * @param {?string} error
- * @param {!Array<!Protocol.CSS.RuleUsage>=} ruleUsage
- * @return {!Array<!Protocol.CSS.RuleUsage>}
- */
- function usedRulesCallback(error, ruleUsage) {
- if (error || !ruleUsage)
- return [];
-
- return ruleUsage;
- }
+ takeCoverageDelta() {
+ return this._agent.takeCoverageDelta((error, ruleUsage) => error || !ruleUsage ? [] : ruleUsage);
+ }
- return this._agent.stopRuleUsageTracking(usedRulesCallback);
+ /**
+ * @return {!Promise}
+ */
+ stopCoverage() {
+ return this._agent.stopRuleUsageTracking();
}
/**

Powered by Google App Engine
This is Rietveld 408576698