Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2865543002: MD Settings: Internet: Fix IP config visibility (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-internet-detail' is the settings subpage containing details 7 * 'settings-internet-detail' is the settings subpage containing details
8 * for a network. 8 * for a network.
9 */ 9 */
10 (function() { 10 (function() {
(...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 */ 909 */
910 showCellularSim_: function(networkProperties) { 910 showCellularSim_: function(networkProperties) {
911 if (networkProperties.Type != 'Cellular' || 911 if (networkProperties.Type != 'Cellular' ||
912 !networkProperties.Cellular) { 912 !networkProperties.Cellular) {
913 return false; 913 return false;
914 } 914 }
915 return networkProperties.Cellular.Family == 'GSM'; 915 return networkProperties.Cellular.Family == 'GSM';
916 }, 916 },
917 917
918 /** 918 /**
919 * @param {!CrOnc.NetworkProperties} networkProperties
920 * @return {boolean}
921 * @private
922 */
923 showIpConfig_: function(networkProperties) {
924 if (!this.isRememberedOrConnected_(networkProperties))
925 return false;
926 return !!networkProperties.IPAddressConfigType;
927 },
928
929 /**
930 * @param {!Object} curValue 919 * @param {!Object} curValue
931 * @param {!Object} newValue 920 * @param {!Object} newValue
932 * @return {boolean} True if all properties set in |newValue| are equal to 921 * @return {boolean} True if all properties set in |newValue| are equal to
933 * the corresponding properties in |curValue|. Note: Not all properties 922 * the corresponding properties in |curValue|. Note: Not all properties
934 * of |curValue| need to be specified in |newValue| for this to return 923 * of |curValue| need to be specified in |newValue| for this to return
935 * true. 924 * true.
936 * @private 925 * @private
937 */ 926 */
938 allPropertiesMatch_: function(curValue, newValue) { 927 allPropertiesMatch_: function(curValue, newValue) {
939 for (var key in newValue) { 928 for (var key in newValue) {
940 if (newValue[key] != curValue[key]) 929 if (newValue[key] != curValue[key])
941 return false; 930 return false;
942 } 931 }
943 return true; 932 return true;
944 } 933 }
945 }); 934 });
946 })(); 935 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698