Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: chrome/browser/android/vr_shell/vr_core_info.h

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Nit: only create native-Java enum if enable_vr is set Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_core_info.h
diff --git a/chrome/browser/android/vr_shell/vr_core_info.h b/chrome/browser/android/vr_shell/vr_core_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..5b0277bc127229993aec14d850c8627b7e7a94c6
--- /dev/null
+++ b/chrome/browser/android/vr_shell/vr_core_info.h
@@ -0,0 +1,37 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_VR_SHELL_VR_CORE_INFO_H_
+#define CHROME_BROWSER_ANDROID_VR_SHELL_VR_CORE_INFO_H_
+
+#include "third_party/gvr-android-sdk/src/libraries/headers/vr/gvr/capi/include/gvr_types.h"
+
+namespace vr_shell {
+
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.vr_shell
+enum VrCoreCompatibility {
+ VR_CORE_COMPATIBILITY_VR_NOT_SUPPORTED = 0,
+ VR_CORE_COMPATIBILITY_VR_NOT_AVAILABLE = 1,
+ VR_CORE_COMPATIBILITY_VR_OUT_OF_DATE = 2,
+ VR_CORE_COMPATIBILITY_VR_READY = 3,
+
+ VR_CORE_COMPATIBILITY_LAST = VR_CORE_COMPATIBILITY_VR_READY,
+};
+
+class VrCoreInfo {
ddorwin 2017/05/24 07:31:37 struct and remove `public`?
tiborg 2017/05/25 00:06:02 Done.
+ public:
+ const gvr_version gvr_version;
+ const VrCoreCompatibility compatibility;
+
+ VrCoreInfo(int32_t major_version,
+ int32_t minor_version,
+ int32_t patch_version,
+ VrCoreCompatibility compatibility)
+ : gvr_version({major_version, minor_version, patch_version}),
+ compatibility(compatibility) {}
+};
+
+} // namespace vr_shell
+
+#endif // CHROME_BROWSER_ANDROID_VR_SHELL_VR_CORE_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698