chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java - Issue 2865463003: Tracks GVR version crossed with headset type using UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)

Patch Set: Nit: only create native-Java enum if enable_vr is set Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/browser/android/vr_shell/BUILD.gn » ('j') | chrome/browser/android/vr_shell/vr_core_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java

index 1e35cec870127a4f2df85a33158b4e765ec052d8..06641a1642afbee2e74c3cf75bdf19e9a8996699 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/MockVrCoreVersionCheckerImpl.java

@@ -14,9 +14,8 @@ public class MockVrCoreVersionCheckerImpl extends VrCoreVersionCheckerImpl {

private int mLastReturnValue = -1;

@Override

- public int getVrCoreCompatibility() {

- mLastReturnValue =

- mUseActualImplementation ? super.getVrCoreCompatibility() : mMockReturnValue;

+ public int getVrCoreInfo() {

+ mLastReturnValue = mUseActualImplementation ? super.getVrCoreInfo() : mMockReturnValue;

return mLastReturnValue;

}