Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4252)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Rebased on ToT, changed logging to UMA_HISTOGRAM_SPARSE_SLOWLY Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
index 6ea8491b9e3b41178fd4b9e600c6f154c81474e1..fcd7ec746a7822822fb804e3c547f9587cc44b02 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
@@ -764,7 +764,7 @@ public class VrShellDelegate implements ApplicationStatus.ActivityStateListener,
private static boolean isVrCoreCompatible(
VrCoreVersionChecker versionChecker, Tab tabToShowInfobarIn) {
- int vrCoreCompatibility = versionChecker.getVrCoreCompatibility();
+ int vrCoreCompatibility = versionChecker.getVrCoreInfo().compatibility;
if (vrCoreCompatibility == VrCoreVersionChecker.VR_NOT_AVAILABLE
|| vrCoreCompatibility == VrCoreVersionChecker.VR_OUT_OF_DATE) {
@@ -902,6 +902,11 @@ public class VrShellDelegate implements ApplicationStatus.ActivityStateListener,
return mNativeVrShellDelegate;
}
+ @CalledByNative
+ private VrCoreInfo getVrCoreInfo() {
+ return (mVrCoreVersionChecker != null) ? mVrCoreVersionChecker.getVrCoreInfo() : null;
+ }
+
private void destroy() {
if (sInstance == null) return;
shutdownVr(true, false);

Powered by Google App Engine
This is Rietveld 408576698