chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java - Issue 2865463003: Tracks GVR version crossed with headset type using UMA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)

Patch Set: Rebased on ToT, changed logging to UMA_HISTOGRAM_SPARSE_SLOWLY Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreInfo.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

index e6f6fbf40606a6b87d8a87776dc8e61369365b55..e6764f2f3c02c5cc59ce0eb33f6ddc1721dbe5e3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

@@ -26,7 +26,8 @@ public interface VrCoreVersionChecker {

public static final String VR_CORE_PACKAGE_ID = "com.google.vr.vrcore";

/**

- * Check if VrCore is installed or if installed version is compatible with Chromium.

+ * Returns the version of VrCore (if it is installed) and the compatibility of VrCore with

+ * Chromium.

ddorwin 2017/05/16 00:15:51 nit: We refer to the product as Chrome in comments

tiborg 2017/05/23 15:47:24 Done.

- int getVrCoreCompatibility();

+ VrCoreInfo getVrCoreInfo();

}