Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2865463003: Tracks GVR version crossed with headset type using UMA. (Closed)
Patch Set: Rebased on ToT, changed logging to UMA_HISTOGRAM_SPARSE_SLOWLY Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 7b2303dccb9969dc8a781e8db719e9c50284764e..58201d9c28f6e6c76214dd8ee2b6058c67f636b3 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -22640,6 +22640,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="GVRVersion" units="code">
ddorwin 2017/05/16 00:15:51 It appears units can be anything. SafeBrowsing.V4S
tiborg 2017/05/23 15:47:25 Done.
+ <owner>tiborg@chromium.org</owner>
+ <summary>The GVR version being used for VR.</summary>
ddorwin 2017/05/16 00:15:51 We should document the magic numbers here so they
tiborg 2017/05/23 15:47:25 Done.
+</histogram>
+
<histogram name="Hardware.Display.Count.OnChange">
<owner>erikchen@chromium.org</owner>
<summary>
@@ -85847,6 +85852,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="GPU.ContextMemory.WebGL"/>
</histogram_suffixes>
+<histogram_suffixes name="GVRVersionHeadset" separator=".">
+ <suffix name="Cardboard" label="GVR version used with Carboard."/>
+ <suffix name="Daydream" label="GVR version used with Daydream."/>
+ <suffix name="Unknown" label="GVR version used with an unknown headset."/>
ddorwin 2017/05/16 00:15:51 This would need to be GVR.Unknown if we're going t
tiborg 2017/05/23 15:47:25 If we are going to report GVR versions, which are
+ <affected-histogram name="GVRVersion"/>
+</histogram_suffixes>
+
<histogram_suffixes name="GWSChromeJointExperiment">
<suffix name="Experiment1"
label="Only page loads that are a result of a navigation from a web

Powered by Google App Engine
This is Rietveld 408576698