Tracks GVR version crossed with headset type using UMA.

chrome/browser/android/vr_shell/vr_usage_monitor.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_usage_monitor.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/browser_process.h"
 #include "components/rappor/public/rappor_utils.h"
@@ skipping 105 matching lines @@
 
   void SendAccumulatedSessionTime() override {
     if (!accumulated_time_.is_zero()) {
       UMA_HISTOGRAM_CUSTOM_TIMES(HistogramNameFromSessionType(sessionType),
                                  accumulated_time_, base::TimeDelta(),
                                  base::TimeDelta::FromHours(5), 100);
     }
   }
 };
 
+bool VrMetricsHelper::logged_gvr_version_ = false;
+
 void SessionTimer::StartSession(base::Time start_time) {
   // If the new start time is within the minimum session gap time from the last
   // stop, continue the previous session.
   // Otherwise, start a new session, sending the event for the last session.
   if (!stop_time_.is_null() &&
       start_time - stop_time_ <= maximum_session_gap_time_) {
     // Mark the previous segment as non-continuable, sending data and clearing
     // state.
     StopSession(false, stop_time_);
   }
@@ skipping 33 matching lines @@
   } else if (is_webvr_) {
     mode = VRMode::WEBVR;
   } else {
     mode = is_fullscreen_ ? VRMode::VR_FULLSCREEN : VRMode::VR_BROWSER;
   }
 
   if (mode != mode_)
     SetVrMode(mode);
 }
 
+ViewerType VrMetricsHelper::GetVrViewerType(gvr_context* context) {
+  auto gvr_api = gvr::GvrApi::WrapNonOwned(context);
+  switch (gvr_api->GetViewerType()) {
+    case gvr::ViewerType::GVR_VIEWER_TYPE_DAYDREAM:
+      return ViewerType::DAYDREAM;
+    case gvr::ViewerType::GVR_VIEWER_TYPE_CARDBOARD:
+      return ViewerType::CARDBOARD;
+    default:
+      NOTREACHED();
+      return ViewerType::UNKNOWN_TYPE;
+  }
+}
+
 void VrMetricsHelper::SetWebVREnabled(bool is_webvr_presenting) {
   is_webvr_ = is_webvr_presenting;
   UpdateMode();
 }
 
 void VrMetricsHelper::SetVRActive(bool is_vr_enabled) {
   is_vr_enabled_ = is_vr_enabled;
   UpdateMode();
 }
 
+void VrMetricsHelper::LogGvrVersionAndVrViewerType(gvr_context* context,
+                                                   gvr_version version) {
+  if (!logged_gvr_version_) {
+    // Resolves to GVR_OTHER. Should not happen.
+    int gvr_version_numeric = static_cast<int>(
+        GVRVersionCrossedVRViewerType::GVR_OTHER_AND_UNKNOWN_TYPE);
+    if (version.major < 0) {
+      gvr_version_numeric =
+          static_cast<int>(GVRVersionCrossedVRViewerType::GVR_NONE);
+    } else if (version.major < 1) {
+      gvr_version_numeric = 0;
+    } else if (version.major == 1 && version.major <= 40) {
+      switch (version.minor) {
+        case 10:
+          gvr_version_numeric = static_cast<int>(
+              GVRVersionCrossedVRViewerType::GVR_1_10_AND_UNKNOWN_TYPE);
+          break;
+        case 20:
+          gvr_version_numeric = static_cast<int>(
+              GVRVersionCrossedVRViewerType::GVR_1_20_AND_UNKNOWN_TYPE);
+          break;
+        case 30:
+          gvr_version_numeric = static_cast<int>(
+              GVRVersionCrossedVRViewerType::GVR_1_30_AND_UNKNOWN_TYPE);
+          break;
+        case 40:
+          gvr_version_numeric = static_cast<int>(
+              GVRVersionCrossedVRViewerType::GVR_1_40_AND_UNKNOWN_TYPE);
+          break;
+      }
+    } else {
+      gvr_version_numeric = static_cast<int>(
+          GVRVersionCrossedVRViewerType::GVR_NEWER_AND_UNKNOWN_TYPE);
+    }
+    ViewerType vr_viewer_type =
+        context ? GetVrViewerType(context) : ViewerType::UNKNOWN_TYPE;
+
+    int datum = static_cast<int>(vr_viewer_type) * 7 + gvr_version_numeric;

[ddorwin, 2017/05/05 20:29:59]

Magic number. Also, this doesn't seem maintainable.

[tiborg, 2017/05/10 20:39:52]

It's gone in favor of the UMA_HISTOGRAM_SPARSE_SLOWLY solution.

+    UMA_HISTOGRAM_ENUMERATION(
+        "GVRVersionCrossedVRViewerType", datum,
+        static_cast<int>(GVRVersionCrossedVRViewerType::
+                             GVR_VERSION_CROSSED_VR_VIEWER_TYPE_MAX));
+    logged_gvr_version_ = true;
+  }
+}
+
+void VrMetricsHelper::LogVrViewerType(gvr_context* context) {
+  UMA_HISTOGRAM_ENUMERATION("VRViewerType",
+                            static_cast<int>(GetVrViewerType(context)),
+                            static_cast<int>(ViewerType::VIEWER_TYPE_MAX));
+}
+
 void VrMetricsHelper::SetVrMode(VRMode mode) {
   DCHECK(mode != mode_);
 
   base::Time switchTime = base::Time::Now();
 
   // stop the previous modes
   if (mode_ != VRMode::NO_VR) {
     if (num_videos_playing_ > 0)
       mode_video_timer_->StopSession(false, switchTime);
 
@@ skipping 130 matching lines @@
   }
 }
 
 void VrMetricsHelper::DidToggleFullscreenModeForTab(bool entered_fullscreen,
                                                     bool will_cause_resize) {
   is_fullscreen_ = entered_fullscreen;
   UpdateMode();
 }
 
 }  // namespace vr_shell