Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_web_contents_delegate.h" 5 #include "android_webview/native/aw_web_contents_delegate.h"
6 6
7 #include "android_webview/browser/aw_javascript_dialog_manager.h" 7 #include "android_webview/browser/aw_javascript_dialog_manager.h"
8 #include "android_webview/browser/find_helper.h" 8 #include "android_webview/browser/find_helper.h"
9 #include "android_webview/native/aw_contents.h" 9 #include "android_webview/native/aw_contents.h"
10 #include "android_webview/native/aw_contents_io_thread_client_impl.h" 10 #include "android_webview/native/aw_contents_io_thread_client_impl.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 return; 69 return;
70 70
71 aw_contents->GetFindHelper()->HandleFindReply(request_id, 71 aw_contents->GetFindHelper()->HandleFindReply(request_id,
72 number_of_matches, 72 number_of_matches,
73 active_match_ordinal, 73 active_match_ordinal,
74 final_update); 74 final_update);
75 } 75 }
76 76
77 void AwWebContentsDelegate::CanDownload( 77 void AwWebContentsDelegate::CanDownload(
78 content::RenderViewHost* source, 78 content::RenderViewHost* source,
79 int request_id, 79 const GURL& url,
80 const std::string& request_method, 80 const std::string& request_method,
81 const base::Callback<void(bool)>& callback) { 81 const base::Callback<void(bool)>& callback) {
82 // Android webview intercepts download in its resource dispatcher host 82 // Android webview intercepts download in its resource dispatcher host
83 // delegate, so should not reach here. 83 // delegate, so should not reach here.
84 NOTREACHED(); 84 NOTREACHED();
85 callback.Run(false); 85 callback.Run(false);
86 } 86 }
87 87
88 void AwWebContentsDelegate::RunFileChooser(WebContents* web_contents, 88 void AwWebContentsDelegate::RunFileChooser(WebContents* web_contents,
89 const FileChooserParams& params) { 89 const FileChooserParams& params) {
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 DVLOG(0) << "File Chooser result: mode = " << mode 240 DVLOG(0) << "File Chooser result: mode = " << mode
241 << ", file paths = " << JoinString(file_path_str, ":"); 241 << ", file paths = " << JoinString(file_path_str, ":");
242 rvh->FilesSelectedInChooser(files, mode); 242 rvh->FilesSelectedInChooser(files, mode);
243 } 243 }
244 244
245 bool RegisterAwWebContentsDelegate(JNIEnv* env) { 245 bool RegisterAwWebContentsDelegate(JNIEnv* env) {
246 return RegisterNativesImpl(env); 246 return RegisterNativesImpl(env);
247 } 247 }
248 248
249 } // namespace android_webview 249 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_web_contents_delegate.h ('k') | chrome/browser/apps/web_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698