pkg/front_end/testcases/inference/map_literals.dart - Issue 2865403007: Get rid of promotedType=none annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/testcases/inference/map_literals.dart

Issue 2865403007: Get rid of promotedType=none annotations (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/testcases/inference/local_reference_upwards_local.dart ('k') | pkg/front_end/testcases/inference/map_literals_can_infer_null.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/testcases/inference/map_literals.dart

diff --git a/pkg/front_end/testcases/inference/map_literals.dart b/pkg/front_end/testcases/inference/map_literals.dart

index 99ac59ab9f9ebd6613d2face0bd82ef6f08ca987..3fff864cff2e98ee103bfd85c23a57ee4d954f86 100644

--- a/pkg/front_end/testcases/inference/map_literals.dart

+++ b/pkg/front_end/testcases/inference/map_literals.dart

@@ -7,14 +7,13 @@ library test;

test1() {

var /*@type=Map<int, String>*/ x = /*@typeArgs=int, String*/ {1: 'x', 2: 'y'};

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [3] = 'z';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [

+ x /*@target=Map::[]=*/ [3] = 'z';

+ x /*@target=Map::[]=*/ [

/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/ 'hi'] = 'w';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [

+ x /*@target=Map::[]=*/ [

/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/ 4.0] = 'u';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [

- 3] = /*error:INVALID_ASSIGNMENT*/ 42;

- Map<num, String> y = /*@promotedType=none*/ x;

+ x /*@target=Map::[]=*/ [3] = /*error:INVALID_ASSIGNMENT*/ 42;

+ Map<num, String> y = x;

}

test2() {

@@ -23,13 +22,12 @@ test2() {

2: 'y',

3.0: new RegExp('.')

};

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [3] = 'z';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [

+ x /*@target=Map::[]=*/ [3] = 'z';

+ x /*@target=Map::[]=*/ [

/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/ 'hi'] = 'w';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [4.0] = 'u';

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [

- 3] = /*error:INVALID_ASSIGNMENT*/ 42;

+ x /*@target=Map::[]=*/ [4.0] = 'u';

+ x /*@target=Map::[]=*/ [3] = /*error:INVALID_ASSIGNMENT*/ 42;

Pattern p = null;

- /*@promotedType=none*/ x /*@target=Map::[]=*/ [2] = /*@promotedType=none*/ p;

- Map<int, String> y = /*info:ASSIGNMENT_CAST*/ /*@promotedType=none*/ x;

+ x /*@target=Map::[]=*/ [2] = p;

+ Map<int, String> y = /*info:ASSIGNMENT_CAST*/ x;

}