Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2865403007: Get rid of promotedType=none annotations (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of promotedType=none annotations These turned out to be really unweildy. Besides, they aren't necessary since the test framework will flag a failure if a type gets promoted when it is not expected to be. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/99d9a77be8d7a03a99facf96001a9f282f1ffa75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -661 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_futures.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_all_returns_are_values.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_mix_of_values_and_futures.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_async_star.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_basic.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_async_star.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_infer_bottom_sync_star.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_lub.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_nested_lambdas.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_no_return.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/block_bodied_lambdas_sync_star.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_const_with_upper_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_downwards_from_constructor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart View 1 chunk +6 lines, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/downward_inference_miscellaneous.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_async_await.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +7 lines, -11 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart View 1 chunk +9 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/testcases/inference/future_or_subtyping.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_2.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_3.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_4.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_5.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_6.dart View 1 chunk +19 lines, -27 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional.dart View 1 chunk +13 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_2.dart View 1 chunk +13 lines, -19 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_3.dart View 1 chunk +13 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_4.dart View 1 chunk +13 lines, -19 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_5.dart View 1 chunk +13 lines, -19 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_conditional_6.dart View 1 chunk +13 lines, -21 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_downwards_method_target.dart View 1 chunk +7 lines, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_explicit_future.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_3.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/future_then_upwards_from_block.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_async_conditional_2.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_generic_return.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_downwards_inference_fold.dart View 1 chunk +13 lines, -11 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_infer_generic_method_type.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_inference_error.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +23 lines, -26 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_nested_generic_instantiation.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_generic_method_type_required.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_return_of_statement_lambda.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop.dart View 1 chunk +23 lines, -25 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_loop_with_inference.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_index_op.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_custom_index_op_via_interface.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_multiple_levels_of_nesting.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_via_closure_type_depends_on_args.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/lambda_does_not_have_propagated_type_hint.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/list_literals.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/local_constructor_from_arguments.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/local_reference_upwards_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/map_literals.dart View 2 chunks +11 lines, -13 lines 0 comments Download
M pkg/front_end/testcases/inference/map_literals_can_infer_null.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/map_literals_top_level.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_coalescing_operator.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/null_coalescing_operator_2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_literal_should_not_infer_as_bottom.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_to_field_in_class.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_to_field_in_class_dynamic_warnings.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively2.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_variable_get.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_double.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_int.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/refine_binary_expression_type_type_parameter_t_t.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/testcases/inference/string_literal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_cast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_simple.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr1.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr1.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_implicit_type_param_via_expr.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_dynamic_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_explicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/unsafe_block_closure_inference_method_call_implicit_type_param.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-11 18:00:09 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-11 18:03:48 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-11 18:14:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99d9a77be8d7a03a99facf96001a9f282f1ffa75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698