Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2865403005: Remove an obsolete error from the spec and an obsolete command-line flag (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, jwren
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove an obsolete error from the spec and an obsolete command-line flag R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a3ac4253b1a914620e33ce7b868cea8795c01d08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -80 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +4 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 4 chunks +0 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-10 16:31:33 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 16:33:02 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-10 16:33:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3ac4253b1a914620e33ce7b868cea8795c01d08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698